Cherry Pick PR #7075 to release-1.147#7134
Merged
cheftako merged 2 commits intoMar 20, 2026
Merged
Conversation
This change introduces a 'skip-name-validation' flag across various controllers to bypass the duplicate controller name check during registration. This is particularly useful for integration tests where multiple managers might be created in the same process, avoiding conflicts in controller-runtime's global name registry. Additionally, consolidated 'kccmanager_skipnamevalidation_test.go' into 'kccmanager_test.go'.
- Use k8s.io/utils/ptr.To instead of taking address of struct fields for controller options. - Clarify SkipNameValidation comments and flag description. - Add note about global state in controller-runtime during tests.
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cheftako The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
6608419
into
GoogleCloudPlatform:release-1.147
18 of 182 checks passed
Collaborator
|
/retest |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR cherry-picks the changes from PR #7075 to the release-1.147 branch