feat: add Go types for CloudBuildTrigger#6926
Conversation
This commit introduces the necessary Go types and generate.sh for CloudBuildTrigger in apis/cloudbuild/v1beta1/ to migrate the resource from the Terraform controller to the direct controller. The schema matches the existing CRD exactly to ensure backward compatibility. Issue GoogleCloudPlatform#6923
codebot-robot
left a comment
There was a problem hiding this comment.
Addressed CI failure by adding missing copyright headers and updating the year to 2026 for CloudBuildTrigger mappings.
--- INVESTIGATION REPORT ---
|
cheftako
left a comment
There was a problem hiding this comment.
Please only change the copyright year on new files.
| See the License for the specific language governing permissions and | ||
| limitations under the License. | ||
| */ | ||
| // Copyright 2026 Google LLC |
There was a problem hiding this comment.
pkg/controller/direct/cloudbuild/workerpool_mappings.go is not a new file. As such we should not be changing the copyright year on this file. Please change it back to 2024.
codebot-robot
left a comment
There was a problem hiding this comment.
Reverted the copyright year in back to 2024 as it is not a new file. Verified that new files added in this PR maintain the 2026 copyright year.
codebot-robot
left a comment
There was a problem hiding this comment.
Reverted the copyright year in pkg/controller/direct/cloudbuild/workerpool_mappings.go back to 2024 as it is not a new file. Verified that new files added in this PR maintain the 2026 copyright year.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cheftako The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
codebot-robot
left a comment
There was a problem hiding this comment.
Thanks for the approval! I've verified that all review comments are addressed, including reverting the copyright year for existing files and ensuring the CloudBuildTrigger types are correctly generated and equivalent to the CRD.
ec56916
This PR adds the Go types and
generate.shscript forCloudBuildTriggeras requested in Issue #6923.It ensures that:
generate.shfile generates types forgoogle.devtools.cloudbuild.v1.check_crd_equivalenceaccepts it.status.observedGenerationis correctly typed as*int64.generate-mapperbuilds without issues, including some custom mappings where needed.This PR was generated by the gemini-3-flash-preview model.
Fixes #6923