-
Notifications
You must be signed in to change notification settings - Fork 2.9k
feat: update sample to use beam-side lite io #5312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Is it possible to add https://github.com/orgs/googleapis/teams/api-pubsublite as a reviewer here? |
|
@api-pubsublite PLEASE REVEIW |
|
@anguillanneuf I can't invite teams from another org, we can try to create a replicate team in this org, however. Could you invite an individual to review this? If you can't add them directly, you can mention them in a comment. |
|
@lesv A replicate team for https://github.com/orgs/googleapis/teams/api-pubsublite is the best. I chatted with @manuelmenzella-google, we decided to punt on it until the I/O connector released with Beam is stable, which could be another month or two. Update: Once https://github.com/orgs/googlecloudplatform/teams/api-pubsub-and-pubsublite is ready. We can add it as a reviewer. |
|
@anguillanneuf Looks like there needs to be some manual work at this point. |
|
@anguillanneuf What's the plan for this? Will it ever be merged or should we close it? |
No region tags are edited in this PR.This comment is generated by snippet-bot.
|
Pub/Sub Lite maintains two I/O connectors to Beam.
This PR updates the original sample to use the Beam-side
PubsubLiteIO.Wait to merge this PR after getting approvals from the Pub/Sub Lite team.
Chatted with @manuelmenzella-google, let's wait to merge it after the Beam-side I/O is stable.