Skip to content

Conversation

@renovate-bot
Copy link
Contributor

@renovate-bot renovate-bot commented Nov 4, 2020

This PR contains the following updates:

Package Update Change
com.google.cloud:libraries-bom major 13.4.0 -> 14.4.1

Renovate configuration

📅 Schedule: At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻️ Rebasing: Never, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by WhiteSource Renovate. View repository job log here.

@renovate-bot renovate-bot requested a review from a team November 4, 2020 02:43
@forking-renovate forking-renovate bot added the automerge Merge the pull request once unit tests and other checks pass. label Nov 4, 2020
@trusted-contributions-gcf trusted-contributions-gcf bot added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 4, 2020
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Nov 4, 2020
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 4, 2020
@gcf-merge-on-green
Copy link
Contributor

Your PR has attempted to merge for 3 hours. Please check that all required checks have passed, you have an automerge label, and that all your reviewers have approved the PR

@gcf-merge-on-green
Copy link
Contributor

Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, or one of your required reviews was not approved. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot.

1 similar comment
@gcf-merge-on-green
Copy link
Contributor

Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, or one of your required reviews was not approved. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot.

@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Nov 4, 2020
@lesv
Copy link
Contributor

lesv commented Nov 4, 2020

Lint

#
# appengine-java11/guestbook-cloud-firestore
#

[ERROR] Failed to execute goal org.apache.maven.plugins:maven-checkstyle-plugin:3.1.1:check (default-cli) on project guestbook-cloud-firestore: Execution default-cli of goal org.apache.maven.plugins:maven-checkstyle-plugin:3.1.1:check failed: Plugin org.apache.maven.plugins:maven-checkstyle-plugin:3.1.1 or one of its dependencies could not be resolved: Could not transfer artifact org.sonatype.sisu:sisu-inject-plexus:jar:1.4.2 from/to central (https://repo.maven.apache.org/maven2): /root/.m2/repository/org/sonatype/sisu/sisu-inject-plexus/1.4.2/sisu-inject-plexus-1.4.2.jar.part (No such file or directory) -> [Help 1]

#
# appengine-java8/pubsub
#

[ERROR] Failed to execute goal org.apache.maven.plugins:maven-checkstyle-plugin:3.1.1:check (default-cli) on project appengine-pubsub: Execution default-cli of goal org.apache.maven.plugins:maven-checkstyle-plugin:3.1.1:check failed: Plugin org.apache.maven.plugins:maven-checkstyle-plugin:3.1.1 or one of its dependencies could not be resolved: Could not transfer artifact org.apache.maven:maven-model:jar:3.0 from/to central (https://repo.maven.apache.org/maven2): /root/.m2/repository/org/apache/maven/maven-model/3.0/maven-model-3.0.jar.part (No such file or directory) -> [Help 1]

@lesv lesv added automerge Merge the pull request once unit tests and other checks pass. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Nov 4, 2020
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 4, 2020
@renovate-bot renovate-bot force-pushed the renovate/com.google.cloud-libraries-bom-14.x branch from 415770c to c2ebfe6 Compare November 4, 2020 19:31
@trusted-contributions-gcf trusted-contributions-gcf bot added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 4, 2020
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 4, 2020
@lesv
Copy link
Contributor

lesv commented Nov 4, 2020

Argh - this time Java 11 & Java 8 fail, but lint passes. I hate it when kokoro goes wonky, then Spanner get's unhappy.

Java 11

------------------------------------------------------------
- testing spanner/cloud-client
------------------------------------------------------------
[ERROR] Tests run: 3, Failures: 0, Errors: 2, Skipped: 0, Time elapsed: 1,070.514 s <<< FAILURE! - in com.example.spanner.SpannerSampleIT
[ERROR] com.example.spanner.SpannerSampleIT.testSample  Time elapsed: 1,054.292 s  <<< ERROR!
com.google.cloud.spanner.SpannerException:
RESOURCE_EXHAUSTED: com.google.api.gax.rpc.ResourceExhaustedException: io.grpc.StatusRuntimeException: RESOURCE_EXHAUSTED: Quota exceeded for quota metric 'Administrative requests' and limit 'Administrative requests per minute' of service 'spanner.googleapis.com' for consumer 'project_number:779844219229'.
links {
  description: "Google developer console API key"
  url: "https://console.developers.google.com/project/779844219229/apiui/credential"
}

	at com.example.spanner.SpannerSampleIT.runSample(SpannerSampleIT.java:61)
	at com.example.spanner.SpannerSampleIT.testSample(SpannerSampleIT.java:342)
Caused by: java.util.concurrent.ExecutionException:
com.google.api.gax.rpc.ResourceExhaustedException: io.grpc.StatusRuntimeException: RESOURCE_EXHAUSTED: Quota exceeded for quota metric 'Administrative requests' and limit 'Administrative requests per minute' of service 'spanner.googleapis.com' for consumer 'project_number:779844219229'.
links {
  description: "Google developer console API key"
  url: "https://console.developers.google.com/project/779844219229/apiui/credential"
}

	at com.example.spanner.SpannerSampleIT.runSample(SpannerSampleIT.java:61)
	at com.example.spanner.SpannerSampleIT.testSample(SpannerSampleIT.java:342)
Caused by: com.google.api.gax.rpc.ResourceExhaustedException:
io.grpc.StatusRuntimeException: RESOURCE_EXHAUSTED: Quota exceeded for quota metric 'Administrative requests' and limit 'Administrative requests per minute' of service 'spanner.googleapis.com' for consumer 'project_number:779844219229'.
links {
  description: "Google developer console API key"
  url: "https://console.developers.google.com/project/779844219229/apiui/credential"
}

Caused by: io.grpc.StatusRuntimeException:
RESOURCE_EXHAUSTED: Quota exceeded for quota metric 'Administrative requests' and limit 'Administrative requests per minute' of service 'spanner.googleapis.com' for consumer 'project_number:779844219229'.
links {
  description: "Google developer console API key"
  url: "https://console.developers.google.com/project/779844219229/apiui/credential"
}


[ERROR] com.example.spanner.SpannerSampleIT  Time elapsed: 1,054.318 s  <<< ERROR!
com.google.cloud.spanner.SpannerException:
RESOURCE_EXHAUSTED: com.google.api.gax.rpc.ResourceExhaustedException: io.grpc.StatusRuntimeException: RESOURCE_EXHAUSTED: Quota exceeded for quota metric 'Administrative requests' and limit 'Administrative requests per minute' of service 'spanner.googleapis.com' for consumer 'project_number:779844219229'.
links {
  description: "Google developer console API key"
  url: "https://console.developers.google.com/project/779844219229/apiui/credential"
}

	at com.example.spanner.SpannerSampleIT.tearDown(SpannerSampleIT.java:79)
Caused by: java.util.concurrent.ExecutionException:
com.google.api.gax.rpc.ResourceExhaustedException: io.grpc.StatusRuntimeException: RESOURCE_EXHAUSTED: Quota exceeded for quota metric 'Administrative requests' and limit 'Administrative requests per minute' of service 'spanner.googleapis.com' for consumer 'project_number:779844219229'.
links {
  description: "Google developer console API key"
  url: "https://console.developers.google.com/project/779844219229/apiui/credential"
}

	at com.example.spanner.SpannerSampleIT.tearDown(SpannerSampleIT.java:79)
Caused by: com.google.api.gax.rpc.ResourceExhaustedException:
io.grpc.StatusRuntimeException: RESOURCE_EXHAUSTED: Quota exceeded for quota metric 'Administrative requests' and limit 'Administrative requests per minute' of service 'spanner.googleapis.com' for consumer 'project_number:779844219229'.
links {
  description: "Google developer console API key"
  url: "https://console.developers.google.com/project/779844219229/apiui/credential"
}

Caused by: io.grpc.StatusRuntimeException:
RESOURCE_EXHAUSTED: Quota exceeded for quota metric 'Administrative requests' and limit 'Administrative requests per minute' of service 'spanner.googleapis.com' for consumer 'project_number:779844219229'.
links {
  description: "Google developer console API key"
  url: "https://console.developers.google.com/project/779844219229/apiui/credential"
}


[ERROR] Tests run: 2, Failures: 0, Errors: 2, Skipped: 0, Time elapsed: 0.136 s <<< FAILURE! - in com.example.spanner.AsyncExamplesIT
[ERROR] com.example.spanner.AsyncExamplesIT  Time elapsed: 0.129 s  <<< ERROR!
java.util.concurrent.ExecutionException:
com.google.cloud.spanner.SpannerException: RESOURCE_EXHAUSTED: io.grpc.StatusRuntimeException: RESOURCE_EXHAUSTED: Quota exceeded for quota metric 'Administrative requests' and limit 'Administrative requests per minute' of service 'spanner.googleapis.com' for consumer 'project_number:779844219229'.
links {
  description: "Google developer console API key"
  url: "https://console.developers.google.com/project/779844219229/apiui/credential"
}

	at com.example.spanner.AsyncExamplesIT.createTestDatabase(AsyncExamplesIT.java:106)
Caused by: com.google.cloud.spanner.SpannerException:
RESOURCE_EXHAUSTED: io.grpc.StatusRuntimeException: RESOURCE_EXHAUSTED: Quota exceeded for quota metric 'Administrative requests' and limit 'Administrative requests per minute' of service 'spanner.googleapis.com' for consumer 'project_number:779844219229'.
links {
  description: "Google developer console API key"
  url: "https://console.developers.google.com/project/779844219229/apiui/credential"
}

	at com.example.spanner.AsyncExamplesIT.createTestDatabase(AsyncExamplesIT.java:88)
Caused by: io.grpc.StatusRuntimeException:
RESOURCE_EXHAUSTED: Quota exceeded for quota metric 'Administrative requests' and limit 'Administrative requests per minute' of service 'spanner.googleapis.com' for consumer 'project_number:779844219229'.
links {
  description: "Google developer console API key"
  url: "https://console.developers.google.com/project/779844219229/apiui/credential"
}


[ERROR] com.example.spanner.AsyncExamplesIT  Time elapsed: 0.132 s  <<< ERROR!
com.google.cloud.spanner.SpannerException:
RESOURCE_EXHAUSTED: com.google.api.gax.rpc.ResourceExhaustedException: io.grpc.StatusRuntimeException: RESOURCE_EXHAUSTED: Quota exceeded for quota metric 'Administrative requests' and limit 'Administrative requests per minute' of service 'spanner.googleapis.com' for consumer 'project_number:779844219229'.
links {
  description: "Google developer console API key"
  url: "https://console.developers.google.com/project/779844219229/apiui/credential"
}

	at com.example.spanner.AsyncExamplesIT.dropTestDatabase(AsyncExamplesIT.java:111)
Caused by: java.util.concurrent.ExecutionException:
com.google.api.gax.rpc.ResourceExhaustedException: io.grpc.StatusRuntimeException: RESOURCE_EXHAUSTED: Quota exceeded for quota metric 'Administrative requests' and limit 'Administrative requests per minute' of service 'spanner.googleapis.com' for consumer 'project_number:779844219229'.
links {
  description: "Google developer console API key"
  url: "https://console.developers.google.com/project/779844219229/apiui/credential"
}

	at com.example.spanner.AsyncExamplesIT.dropTestDatabase(AsyncExamplesIT.java:111)
Caused by: com.google.api.gax.rpc.ResourceExhaustedException:
io.grpc.StatusRuntimeException: RESOURCE_EXHAUSTED: Quota exceeded for quota metric 'Administrative requests' and limit 'Administrative requests per minute' of service 'spanner.googleapis.com' for consumer 'project_number:779844219229'.
links {
  description: "Google developer console API key"
  url: "https://console.developers.google.com/project/779844219229/apiui/credential"
}

Caused by: io.grpc.StatusRuntimeException:
RESOURCE_EXHAUSTED: Quota exceeded for quota metric 'Administrative requests' and limit 'Administrative requests per minute' of service 'spanner.googleapis.com' for consumer 'project_number:779844219229'.
links {
  description: "Google developer console API key"
  url: "https://console.developers.google.com/project/779844219229/apiui/credential"
}


[ERROR] Tests run: 2, Failures: 0, Errors: 2, Skipped: 0, Time elapsed: 0.083 s <<< FAILURE! - in com.example.spanner.SpannerStandaloneExamplesIT
[ERROR] com.example.spanner.SpannerStandaloneExamplesIT  Time elapsed: 0.078 s  <<< ERROR!
com.google.cloud.spanner.SpannerException:
RESOURCE_EXHAUSTED: com.google.api.gax.rpc.ResourceExhaustedException: io.grpc.StatusRuntimeException: RESOURCE_EXHAUSTED: Quota exceeded for quota metric 'Administrative requests' and limit 'Administrative requests per minute per user' of service 'spanner.googleapis.com' for consumer 'project_number:779844219229'.
links {
  description: "Google developer console API key"
  url: "https://console.developers.google.com/project/779844219229/apiui/credential"
}

	at com.example.spanner.SpannerStandaloneExamplesIT.createTestDatabase(SpannerStandaloneExamplesIT.java:81)
Caused by: java.util.concurrent.ExecutionException:
com.google.api.gax.rpc.ResourceExhaustedException: io.grpc.StatusRuntimeException: RESOURCE_EXHAUSTED: Quota exceeded for quota metric 'Administrative requests' and limit 'Administrative requests per minute per user' of service 'spanner.googleapis.com' for consumer 'project_number:779844219229'.
links {
  description: "Google developer console API key"
  url: "https://console.developers.google.com/project/779844219229/apiui/credential"
}

	at com.example.spanner.SpannerStandaloneExamplesIT.createTestDatabase(SpannerStandaloneExamplesIT.java:81)
Caused by: com.google.api.gax.rpc.ResourceExhaustedException:
io.grpc.StatusRuntimeException: RESOURCE_EXHAUSTED: Quota exceeded for quota metric 'Administrative requests' and limit 'Administrative requests per minute per user' of service 'spanner.googleapis.com' for consumer 'project_number:779844219229'.
links {
  description: "Google developer console API key"
  url: "https://console.developers.google.com/project/779844219229/apiui/credential"
}

Caused by: io.grpc.StatusRuntimeException:
RESOURCE_EXHAUSTED: Quota exceeded for quota metric 'Administrative requests' and limit 'Administrative requests per minute per user' of service 'spanner.googleapis.com' for consumer 'project_number:779844219229'.
links {
  description: "Google developer console API key"
  url: "https://console.developers.google.com/project/779844219229/apiui/credential"
}


[ERROR] com.example.spanner.SpannerStandaloneExamplesIT  Time elapsed: 0.079 s  <<< ERROR!
com.google.cloud.spanner.SpannerException:
RESOURCE_EXHAUSTED: com.google.api.gax.rpc.ResourceExhaustedException: io.grpc.StatusRuntimeException: RESOURCE_EXHAUSTED: Quota exceeded for quota metric 'Administrative requests' and limit 'Administrative requests per minute per user' of service 'spanner.googleapis.com' for consumer 'project_number:779844219229'.
links {
  description: "Google developer console API key"
  url: "https://console.developers.google.com/project/779844219229/apiui/credential"
}

	at com.example.spanner.SpannerStandaloneExamplesIT.dropTestDatabase(SpannerStandaloneExamplesIT.java:102)
Caused by: java.util.concurrent.ExecutionException:
com.google.api.gax.rpc.ResourceExhaustedException: io.grpc.StatusRuntimeException: RESOURCE_EXHAUSTED: Quota exceeded for quota metric 'Administrative requests' and limit 'Administrative requests per minute per user' of service 'spanner.googleapis.com' for consumer 'project_number:779844219229'.
links {
  description: "Google developer console API key"
  url: "https://console.developers.google.com/project/779844219229/apiui/credential"
}

	at com.example.spanner.SpannerStandaloneExamplesIT.dropTestDatabase(SpannerStandaloneExamplesIT.java:102)
Caused by: com.google.api.gax.rpc.ResourceExhaustedException:
io.grpc.StatusRuntimeException: RESOURCE_EXHAUSTED: Quota exceeded for quota metric 'Administrative requests' and limit 'Administrative requests per minute per user' of service 'spanner.googleapis.com' for consumer 'project_number:779844219229'.
links {
  description: "Google developer console API key"
  url: "https://console.developers.google.com/project/779844219229/apiui/credential"
}

Caused by: io.grpc.StatusRuntimeException:
RESOURCE_EXHAUSTED: Quota exceeded for quota metric 'Administrative requests' and limit 'Administrative requests per minute per user' of service 'spanner.googleapis.com' for consumer 'project_number:779844219229'.
links {
  description: "Google developer console API key"
  url: "https://console.developers.google.com/project/779844219229/apiui/credential"
}


[ERROR] Errors:
[ERROR] com.example.spanner.AsyncExamplesIT.null
[ERROR]   Run 1: AsyncExamplesIT.createTestDatabase:106 » Execution com.google.cloud.spanner.Sp...
[ERROR]   Run 2: AsyncExamplesIT.dropTestDatabase:111 » Spanner RESOURCE_EXHAUSTED: com.google....
[ERROR]   SpannerSampleIT.tearDown:79 » Spanner RESOURCE_EXHAUSTED: com.google.api.gax.r...
[ERROR]   SpannerSampleIT.testSample:342->runSample:61 » Spanner RESOURCE_EXHAUSTED: com...
[ERROR] com.example.spanner.SpannerStandaloneExamplesIT.null
[ERROR]   Run 1: SpannerStandaloneExamplesIT.createTestDatabase:81 » Spanner RESOURCE_EXHAUSTED...
[ERROR]   Run 2: SpannerStandaloneExamplesIT.dropTestDatabase:102 » Spanner RESOURCE_EXHAUSTED:...
[ERROR] Tests run: 6, Failures: 0, Errors: 4, Skipped: 0

@lesv
Copy link
Contributor

lesv commented Nov 4, 2020

@olavloite @skuruppu FYI

@lesv
Copy link
Contributor

lesv commented Nov 4, 2020

@olavloite @skuruppu The problem appears to be that spanner.googleapis.com/admin_method_quota 7 day peak is 494 (ie. >300) - I don't appear to be able to request a quota increase for that. (I'll file a bug), but if there was something you could do in the tests to prevent this it would be great.

P.S. why to the tests create and delete instances / do backup & restores in ASIA region?

@lesv lesv added api: spanner Issues related to the Spanner API. priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Nov 4, 2020
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 4, 2020
@lesv
Copy link
Contributor

lesv commented Nov 4, 2020

I've filed a request for a quota increase.

@renovate-bot renovate-bot changed the title chore(deps): update dependency com.google.cloud:libraries-bom to v14 chore(deps): update dependency com.google.cloud:libraries-bom to v14- autoclosed Nov 4, 2020
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Nov 4, 2020
@renovate-bot renovate-bot deleted the renovate/com.google.cloud-libraries-bom-14.x branch November 4, 2020 23:31
@olavloite
Copy link
Contributor

P.S. why to the tests create and delete instances / do backup & restores in ASIA region?

@lesv Good question... What are the names of those instances?

Because:

  1. There is a CreateInstanceExample which is used in a test, but that one explicitly creates one in the US.
  2. The SpannerSampleIT test will only use the existing instance defined in the system property spanner.test.instance. The value of that property is set to default-instance in the pom.
  3. The SpannerStandaloneExamplesIT will use the same instance as SpannerSampleIT.
  4. The AsyncExamplesIT will also use the same existing instance.
  5. The backups that are created during the tests will also be created on the same instance as where the test database is.

CC @skuruppu

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: spanner Issues related to the Spanner API. cla: yes This human has signed the Contributor License Agreement. priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants