chore(deps): update dependency com.google.cloud:libraries-bom to v6 #3179
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lesv
approved these changes
Jun 16, 2020
Contributor
|
Argh - this never works out well, esp on a major bump in version. |
Contributor
|
Your PR has attempted to merge for 3 hours. Please check that all required checks have passed, you have an automerge label, and that all your reviewers have approved the PR |
Contributor
|
Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, or one of your required reviews was not approved. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot. |
Contributor
Java 11It's the usual suspects. |
Contributor
|
Lint passed this time -- huh? |
Contributor
Java 8This didn't fail the first time. :( |
elharo
reviewed
Jun 17, 2020
Contributor
elharo
left a comment
There was a problem hiding this comment.
FYI v6 was a noop. By mistake there were no actual library upgrades in this version.
elharo
reviewed
Jun 17, 2020
Contributor
elharo
left a comment
There was a problem hiding this comment.
Since 6.0.0 is a noop, I'd bet on flaky tests here.
suztomo
reviewed
Jun 17, 2020
| <dependency> | ||
| <groupId>com.google.cloud</groupId> | ||
| <artifactId>libraries-bom</artifactId> | ||
| <version>5.4.0</version> |
Contributor
There was a problem hiding this comment.
Why was this 5.4.0, not 5.7.0?
Contributor
There was a problem hiding this comment.
That was the last version that passed. We are trying to get the spanner team to fix.
suztomo
reviewed
Jun 17, 2020
| <dependency> | ||
| <groupId>com.google.cloud</groupId> | ||
| <artifactId>libraries-bom</artifactId> | ||
| <version>4.4.1</version> |
Contributor
There was a problem hiding this comment.
Why was this still using 4.4.1?
Contributor
There was a problem hiding this comment.
Thatwas the last version that worked.
Autoclosing SkippedThis PR has been flagged for autoclosing, however it is being skipped due to the branch being already modified. Please close/delete it manually or report a bug if you think this is in error. |
Contributor
|
Your PR has attempted to merge for 3 hours. Please check that all required checks have passed, you have an automerge label, and that all your reviewers have approved the PR |
Contributor
|
@lesv Thank you for explanation. Hearing that Spanner (and Dataproc) does not work with the latest GCP Libraries BOM is concerning. Do you have URLs of the issues on Spanner and Dataproc team I should followup? |
elharo
reviewed
Jun 17, 2020
Contributor
elharo
left a comment
There was a problem hiding this comment.
As @suztomo noticed, you had multiple BOM versions prior to this PR. So maybe not flaky, but I'm not sure which update specifically caused the failure. In any case this is not an issue with the BOM, but with changes in the underlying libraries. Perhaps try updating these files one at a time.
Contributor
|
I'm not sure you can fix these problems, and I like that it was a major bump, but you'll note that for things like Spanner - there are missing methods and classes as they've done some big changes. Hopefully the v7 will pick that up and we can get them to fix it. Since you mention that v6 is a noop, I'm going to close this, but the problems still need to be fixed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains the following updates:
5.4.0->6.0.05.7.0->6.0.05.2.0->6.0.05.5.0->6.0.04.4.1->6.0.0Renovate configuration
📅 Schedule: At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻️ Rebasing: Never, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about these updates again.
This PR has been generated by WhiteSource Renovate. View repository job log here.