Spanner: add support for session / pool labels#5734
Merged
Conversation
6b57b0a to
b35edfa
Compare
Read-only, set via ctor.
Use standard mocks for session CRUD.
Read-only, set via ctor. Concrete classes plumb it through their ctors.
33f271d to
bcc8fde
Compare
Contributor
Author
|
/cc @snehashah16 |
mcdonc
suggested changes
Aug 6, 2018
Contributor
mcdonc
left a comment
There was a problem hiding this comment.
Looks good to me, except for the note I added. I'll approve once you address that.
| labels = {} | ||
| self._labels = labels | ||
|
|
||
| @property |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
mcdonc
approved these changes
Aug 6, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Labels are assigned to a pool at creation time, and then get propagated to the sessions created by the pool.