Skip to content

Introduce a complete style guide. #98

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
coryan merged 6 commits into from
Mar 15, 2018
Merged

Introduce a complete style guide. #98

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
303b358
WIP: C++ Style Guide [skip ci]
coryan Dec 13, 2017
5a0a47f
WIP: Working on C++ style guide.
coryan Dec 13, 2017
fbb26a5
Final pass, I think it is complete [skip ci]
coryan Dec 13, 2017
24f6c17
Use Google naming conventions.
coryan Feb 22, 2018
c2912e9
Document how to provide non-exception APIs.
coryan Feb 27, 2018
1f83adc
Address review comments.
coryan Mar 15, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions .clang-format
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,3 +6,16 @@ BasedOnStyle: Google
# (mostly) been using "int& foo", but clang-format(1) sometimes guesses wrong,
# so to enforce the consistency:
PointerAlignment: Left

# These will need to be enabled after we commit the style guide:
# IncludeCategories:
# - Regex: '^\"'
# Priority: 1000
# - Regex: '^<grpc/'
# Priority: 2000
# - Regex: '^<google/*'
# Priority: 3000
# - Regex: '^<.*/.*'
# Priority: 4000
# - Regex: '^<[^/]*>'
# Priority: 5000
19 changes: 10 additions & 9 deletions .clang-tidy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,12 +10,13 @@ Checks: google-readability-*,modernize-*,readability-*,-google-readability-names
WarningsAsErrors: clang-*,google-*,modernize-*,readability-*,-readability-identifier-naming

CheckOptions:
- { key: readability-identifier-naming.NamespaceCase, value: lower_case }
- { key: readability-identifier-naming.ClassCase, value: CamelCase }
- { key: readability-identifier-naming.StructCase, value: CamelCase }
- { key: readability-identifier-naming.FunctionCase, value: CamelCase }
- { key: readability-identifier-naming.VariableCase, value: lower_case }
- { key: readability-identifier-naming.PrivateMemberSuffix, value: _ }
- { key: readability-identifier-naming.ProtectedMemberSuffix, value: _ }
- { key: readability-identifier-naming.MacroDefinition, value: UPPER_CASE }
- { key: readability-identifier-naming.TemplateParameter, value: CamelCase }
- { key: readability-identifier-naming.NamespaceCase, value: lower_case }
- { key: readability-identifier-naming.ClassCase, value: CamelCase }
- { key: readability-identifier-naming.StructCase, value: CamelCase }
- { key: readability-identifier-naming.FunctionCase, value: CamelCase }
- { key: readability-identifier-naming.VariableCase, value: lower_case }
- { key: readability-identifier-naming.PrivateMemberSuffix, value: _ }
- { key: readability-identifier-naming.ProtectedMemberSuffix, value: _ }
- { key: readability-identifier-naming.MacroDefinitionCase, value: UPPER_CASE }
- { key: readability-identifier-naming.EnumConstantCase, value: UPPER_CASE }
- { key: readability-identifier-naming.TemplateParameterCase, value: CamelCase }
Loading