Skip to content

Upgrade gem lock dependency#2209

Merged
Tulsishah merged 1 commit into
masterfrom
dependabot_pr_3
Jul 24, 2024
Merged

Upgrade gem lock dependency#2209
Tulsishah merged 1 commit into
masterfrom
dependabot_pr_3

Conversation

@Tulsishah

@Tulsishah Tulsishah commented Jul 23, 2024

Copy link
Copy Markdown
Contributor

Description

Dependabot dependency
0cb462f

Link to the issue in case of a bug fix.

NA

Testing details

  1. Manual - Package building successfully
  2. Unit tests - NA
  3. Integration tests - NA
  4. Perf tests - B8dees2utG5HZvL

@Tulsishah Tulsishah added execute-perf-test Execute performance test in PR execute-integration-tests Run only integration tests labels Jul 23, 2024
@codecov

codecov Bot commented Jul 23, 2024

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.24%. Comparing base (9955260) to head (3097676).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2209   +/-   ##
=======================================
  Coverage   71.24%   71.24%           
=======================================
  Files         103      103           
  Lines       11393    11393           
=======================================
  Hits         8117     8117           
+ Misses       2941     2940    -1     
- Partials      335      336    +1     
Flag Coverage Δ
unittests 71.24% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Tulsishah Tulsishah marked this pull request as ready for review July 24, 2024 04:39
@Tulsishah Tulsishah requested a review from a team as a code owner July 24, 2024 04:39
@kislaykishore kislaykishore requested review from a team and gargnitingoogle and removed request for a team July 24, 2024 04:39

@ashmeenkaur ashmeenkaur left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is only being used during package building so LGTM if package is building fine after the dependency upgrade

@Tulsishah Tulsishah merged commit 43282a9 into master Jul 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

execute-integration-tests Run only integration tests execute-perf-test Execute performance test in PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants