Skip to content

Setting defaults for parallel downloads#2073

Merged
sethiay merged 2 commits into
masterfrom
pd_defaults
Jun 27, 2024
Merged

Setting defaults for parallel downloads#2073
sethiay merged 2 commits into
masterfrom
pd_defaults

Conversation

@sethiay

@sethiay sethiay commented Jun 27, 2024

Copy link
Copy Markdown
Contributor

Description

Setting defaults for parallel downloads.

Link to the issue in case of a bug fix.

NA

Testing details

  1. Manual - NA
  2. Unit tests - NA
  3. Integration tests - NA

@sethiay sethiay added the execute-integration-tests Run only integration tests label Jun 27, 2024
@codecov

codecov Bot commented Jun 27, 2024

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 71.99%. Comparing base (b8aa8dc) to head (250a1a6).

Files Patch % Lines
cfg/config.go 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2073      +/-   ##
==========================================
- Coverage   72.34%   71.99%   -0.36%     
==========================================
  Files         100       99       -1     
  Lines       11028    10872     -156     
==========================================
- Hits         7978     7827     -151     
+ Misses       2715     2713       -2     
+ Partials      335      332       -3     
Flag Coverage Δ
unittests 71.99% <0.00%> (-0.36%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sethiay sethiay marked this pull request as ready for review June 27, 2024 06:46
@sethiay sethiay requested review from a team and kislaykishore as code owners June 27, 2024 06:46

@kislaykishore kislaykishore left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update params.yaml with the new defaults and generate config.go.

@sethiay sethiay requested a review from kislaykishore June 27, 2024 07:08
@sethiay sethiay merged commit f21483f into master Jun 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

execute-integration-tests Run only integration tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants