Fix race in test#2067
Merged
Merged
Conversation
Shadow the tc variable so that different subtests refer to their corresponding tc. It'd have been fine had the subtests ran sequentially but in a parallel run, different tests sharing the same tc variable can lead to race.
b822e12 to
e439958
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2067 +/- ##
=======================================
Coverage 71.99% 72.00%
=======================================
Files 99 99
Lines 10870 10870
=======================================
+ Hits 7826 7827 +1
+ Misses 2712 2711 -1
Partials 332 332
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
charith87
approved these changes
Jun 26, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Shadow the tc variable so that different subtests refer to their corresponding tc.
It's have been fine had the subtests ran sequentially but in a parallel run, different tests sharing the same tc variable can lead to race.