Skip to content

Use truncate and remove function while eviction from job during CRC check#2015

Merged
sethiay merged 3 commits into
masterfrom
truncate_in_validation
Jun 27, 2024
Merged

Use truncate and remove function while eviction from job during CRC check#2015
sethiay merged 3 commits into
masterfrom
truncate_in_validation

Conversation

@sethiay

@sethiay sethiay commented Jun 13, 2024

Copy link
Copy Markdown
Contributor

Description

Use truncate and remove function while eviction from job during CRC check.

Link to the issue in case of a bug fix.

NA

Testing details

  1. Manual - NA
  2. Unit tests - added
  3. Integration tests - added integration test tag.

@sethiay sethiay added the execute-integration-tests Run only integration tests label Jun 13, 2024
@codecov

codecov Bot commented Jun 13, 2024 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 61.53846% with 5 lines in your changes missing coverage. Please review.

Project coverage is 71.43%. Comparing base (b6eca68) to head (43cef00).
Report is 32 commits behind head on master.

Files Patch % Lines
internal/cache/file/cache_handler.go 33.33% 2 Missing ⚠️
internal/cache/util/util.go 75.00% 1 Missing and 1 partial ⚠️
internal/cache/file/downloader/job.go 50.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #2015      +/-   ##
==========================================
+ Coverage   71.40%   71.43%   +0.03%     
==========================================
  Files          97       97              
  Lines       10708    10709       +1     
==========================================
+ Hits         7646     7650       +4     
+ Misses       2719     2716       -3     
  Partials      343      343
Flag Coverage Δ
unittests 71.43% <61.53%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sethiay sethiay marked this pull request as ready for review June 13, 2024 16:03
@sethiay sethiay requested a review from a team as a code owner June 13, 2024 16:03
@sethiay sethiay force-pushed the truncate_in_validation branch from c1cbba6 to 43cef00 Compare June 17, 2024 12:55
@sethiay sethiay requested a review from vadlakondaswetha June 17, 2024 12:55
@sethiay sethiay added the parallel-downloads Tag to track PRs related to parallel downloads project label Jun 19, 2024
@sethiay sethiay merged commit 9d5cbea into master Jun 27, 2024
@BrewTestBot BrewTestBot mentioned this pull request Jun 28, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@raj-prince raj-prince raj-prince approved these changes

@charith87 charith87 Awaiting requested review from charith87 charith87 is a code owner automatically assigned from GoogleCloudPlatform/gcsfuse-codeowners

@vadlakondaswetha vadlakondaswetha Awaiting requested review from vadlakondaswetha

Assignees

No one assigned

Labels

execute-integration-tests Run only integration tests parallel-downloads Tag to track PRs related to parallel downloads project

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sethiay @raj-prince @vadlakondaswetha