refactor: move the bin entrypoint out of index.ts#377
Merged
matthewrobertson merged 1 commit intomasterfrom Oct 29, 2021
Merged
refactor: move the bin entrypoint out of index.ts#377matthewrobertson merged 1 commit intomasterfrom
matthewrobertson merged 1 commit intomasterfrom
Conversation
grant
approved these changes
Oct 29, 2021
This commit moves the call to bootstrap the express server out of index.ts. This is an important change now that we have declarative function signatures because we expect developers to include an import statement for the functions-framework. Before this change doing so would have automatically started the express http server which makes is hard to do things like write unit tests.
1a0026a to
33c5906
Compare
This was referenced Jan 27, 2022
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit moves the call to bootstrap the express server out of
index.ts. This is an important change now that we have declarative
function signatures because we expect developers to include an import
statement for the functions-framework. Before this change doing so would
have automatically started the express http server which makes it hard
to do things like write unit tests.
Fixes #350