Skip to content

Support unknown in match parameter#189

Merged
melinath merged 2 commits into
GoogleCloudPlatform:masterfrom
iyabchen:unknown-target
Jul 8, 2022
Merged

Support unknown in match parameter#189
melinath merged 2 commits into
GoogleCloudPlatform:masterfrom
iyabchen:unknown-target

Conversation

@iyabchen

@iyabchen iyabchen commented Jul 4, 2022

Copy link
Copy Markdown
Contributor

No description provided.

@iyabchen iyabchen requested a review from melinath July 4, 2022 20:12

@melinath melinath left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you add a new test for an invalid org id? for example organizations/whatever

otherwise LGTM

@iyabchen

iyabchen commented Jul 7, 2022

Copy link
Copy Markdown
Contributor Author

could you add a new test for an invalid org id? for example organizations/whatever

otherwise LGTM

Done

@melinath melinath left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@melinath melinath merged commit ec92f4a into GoogleCloudPlatform:master Jul 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants