Skip to content

default to sauth for newer deployments in h4d and a3mega-gcsfuse blue…#5707

Merged
arpit974 merged 1 commit into
GoogleCloudPlatform:developfrom
arpit974:munge_to_sauth_h4d
May 26, 2026
Merged

default to sauth for newer deployments in h4d and a3mega-gcsfuse blue…#5707
arpit974 merged 1 commit into
GoogleCloudPlatform:developfrom
arpit974:munge_to_sauth_h4d

Conversation

@arpit974

@arpit974 arpit974 commented May 26, 2026

Copy link
Copy Markdown
Contributor

default to sauth for newer deployments in h4d and a4mega-gcsfuse blueprints.

Submission Checklist

NOTE: Community submissions can take up to 2 weeks to be reviewed.

Please take the following actions before submitting this pull request.

  • Fork your PR branch from the Toolkit "develop" branch (not main)
  • Test all changes with pre-commit in a local branch #
  • Confirm that "make tests" passes all tests
  • Add or modify unit tests to cover code changes
  • Ensure that unit test coverage remains above 80%
  • Update all applicable documentation
  • Follow Cluster Toolkit Contribution guidelines #

@arpit974 arpit974 requested a review from a team as a code owner May 26, 2026 06:12
@gemini-code-assist

gemini-code-assist Bot commented May 26, 2026

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request updates several deployment blueprints to manage the transition from MUNGE to Slurm Native Authentication. By adjusting the 'enable_slurm_auth' variable, the changes ensure that newer deployments adopt the recommended authentication standard while preserving existing configurations where necessary to avoid regressions.

Highlights

  • Slurm Native Authentication: Enabled 'enable_slurm_auth' by default in h4d and af3-slurm deployment examples to align with the deprecation of MUNGE.
  • Configuration Adjustment: Updated the a3-megagpu-8g blueprint to set 'enable_slurm_auth' to false, maintaining consistent default behavior for that specific configuration.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

@arpit974 arpit974 added the release-breaking-changes Prevents "smooth" re-deploy across versions label May 26, 2026
gemini-code-assist[bot]
gemini-code-assist Bot reviewed May 26, 2026
View reviewed changes

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request aims to enable Slurm Native Authentication by default for several deployment blueprints, adding recommended configuration variables and documentation notes. However, in the a3mega-slurm-gcsfuse-lssd-blueprint.yaml file, the enable_slurm_auth variable was incorrectly set to false, which contradicts the main objective of the PR and should be corrected to true.

Comment thread examples/machine-learning/a3-megagpu-8g/a3mega-slurm-gcsfuse-lssd-blueprint.yaml
@arpit974 arpit974 merged commit 514ff06 into GoogleCloudPlatform:develop May 26, 2026
16 of 79 checks passed
@arpit974 arpit974 changed the title default to sauth for newer deployments in h4d and a4mega-gcsfuse blue… default to sauth for newer deployments in h4d and a3mega-gcsfuse blue… May 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kvenkatachala333 kvenkatachala333 kvenkatachala333 approved these changes

+1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

release-breaking-changes Prevents "smooth" re-deploy across versions

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@arpit974 @kvenkatachala333