Skip to content

[Telemetry] Add support to merge vars from deployment files and CLI --vars#5694

Merged
kadupoornima merged 4 commits into
GoogleCloudPlatform:developfrom
kadupoornima:develop
May 22, 2026
Merged

[Telemetry] Add support to merge vars from deployment files and CLI --vars#5694
kadupoornima merged 4 commits into
GoogleCloudPlatform:developfrom
kadupoornima:develop

Conversation

@kadupoornima

@kadupoornima kadupoornima commented May 21, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

This pull request enhances the telemetry collection mechanism by allowing it to incorporate configuration variables from external deployment files and command-line overrides. By centralizing the blueprint resolution and variable merging logic, the system ensures that telemetry data accurately reflects the actual configuration used during deployment.

Changes:

  • Enhanced Telemetry Data Collection: Updated the telemetry collector to support merging variables from deployment files and CLI arguments, ensuring more accurate data collection.
  • Improved Test Coverage: Updated unit tests to validate variable merging logic for both deployment files and command-line flags.

@kadupoornima kadupoornima requested a review from a team as a code owner May 21, 2026 09:47
@kadupoornima kadupoornima added release-improvements Added to release notes under the "Improvements" heading. release-bugfix Added to release notes under the "Bug fixes" heading. labels May 21, 2026
@kadupoornima

kadupoornima commented May 21, 2026

Copy link
Copy Markdown
Contributor Author

/gemini review

@gemini-code-assist

gemini-code-assist Bot commented May 21, 2026

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the telemetry collection mechanism by allowing it to incorporate configuration variables from external deployment files and command-line overrides. By centralizing the blueprint resolution and variable merging logic, the system ensures that telemetry data accurately reflects the actual configuration used during deployment.

Highlights

  • Enhanced Telemetry Data Collection: Updated the telemetry collector to support merging variables from deployment files and CLI arguments, ensuring more accurate data collection.
  • Refactored Blueprint Resolution: Promoted getBlueprint to GetBlueprint and modularized the logic to handle path resolution and variable merging separately.
  • Improved Test Coverage: Updated unit tests to validate variable merging logic for both deployment files and command-line flags.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

@kadupoornima kadupoornima changed the title [Telemetry] Add support to collect data from deployment files and --vars [Telemetry] Add support to collect data from deployment files and CLI vars May 21, 2026
@kadupoornima kadupoornima changed the title [Telemetry] Add support to collect data from deployment files and CLI vars [Telemetry] Add support to merge vars from deployment files and CLI vars May 21, 2026
gemini-code-assist[bot]
gemini-code-assist Bot reviewed May 21, 2026
View reviewed changes

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request enhances the telemetry collector by allowing it to capture variable overrides from both deployment files and CLI flags. The GetBlueprint function was exported and updated to merge these additional configuration sources, and unit tests were significantly expanded to verify the correct layering and merging of variables. Feedback suggests aligning the telemetry initialization and enablement checks with repository standards, specifically regarding the use of pre-run hooks and the timing of collector initialization.

Comment thread pkg/telemetry/collector_util.go Outdated
@kadupoornima kadupoornima enabled auto-merge (squash) May 21, 2026 09:58
gemini-code-assist[bot]
gemini-code-assist Bot reviewed May 21, 2026
View reviewed changes

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request enhances the telemetry collector by allowing blueprint variables to be overridden via CLI flags and deployment files. The internal getBlueprint function was refactored into an exported GetBlueprint function to access command flags. Unit tests were updated to verify the new variable merging logic. Feedback was provided regarding the lack of documentation for the newly exported function and the removal of error handling in the test suite's file operations.

Comment thread pkg/telemetry/collector_util.go Outdated
Comment thread pkg/telemetry/collector_test.go
@kadupoornima kadupoornima changed the title [Telemetry] Add support to merge vars from deployment files and CLI vars [Telemetry] Add support to merge vars from deployment files and CLI --vars May 21, 2026
@kadupoornima kadupoornima merged commit f437a4f into GoogleCloudPlatform:develop May 22, 2026
12 of 75 checks passed
@kadupoornima kadupoornima deleted the develop branch May 22, 2026 05:57
@kadupoornima kadupoornima restored the develop branch May 22, 2026 05:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SwarnaBharathiMantena SwarnaBharathiMantena SwarnaBharathiMantena approved these changes

+1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

release-bugfix Added to release notes under the "Bug fixes" heading. release-improvements Added to release notes under the "Improvements" heading.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@kadupoornima @SwarnaBharathiMantena