Add PriorityClasses to example Kueue configs#5614
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request updates the example Kueue configuration templates to include a standard set of Kubernetes PriorityClasses. By providing these defaults, the changes improve the out-of-the-box experience for users and ensure that example setups are better prepared for advanced scheduling workloads. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request introduces several PriorityClass definitions—ranging from very-low to very-high—across multiple Kueue configuration templates in various GKE examples. Feedback indicates that these definitions are duplicated across many files, reducing maintainability, and that the priority values assigned are inconsistent with existing templates in the repository. It is recommended to centralize these definitions to ensure consistency and follow best practices for code structure.
|
/assign @jamOne- |
|
/gcbrun |
SwarnaBharathiMantena
left a comment
There was a problem hiding this comment.
Can you please update these files as well: examples/gke-consumption-options/dws-flex-start-queued-provisioning/dws-queues.yaml.tftpl and examples/gke-consumption-options/dws-flex-start-queued-provisioning/tpu-dws-queues.yaml.tftpl
Task: Add PriorityClasses to every example Kueue configs.
Done! |
|
/gcbrun |
Objective
Align the Cluster Toolkit example Kueue configurations with advanced scheduling requirements (such as XPK's super-slicing setup) by including standard PriorityClasses.
Changes
very-low,low,medium,high, andvery-highPriorityClasses to all examplekueue-configuration.yaml.tftplfiles in theexamples/directory.This ensures users starting from our examples have a complete and robust priority setup out of the box.