Skip to content

[Telemetry] Implement local caching to persistently store user config. Remove Firestore dependency completely#5594

Merged
kadupoornima merged 13 commits into
GoogleCloudPlatform:developfrom
kadupoornima:telemetry-19
May 6, 2026
Merged

[Telemetry] Implement local caching to persistently store user config. Remove Firestore dependency completely#5594
kadupoornima merged 13 commits into
GoogleCloudPlatform:developfrom
kadupoornima:telemetry-19

Conversation

@kadupoornima

@kadupoornima kadupoornima commented May 4, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

This pull request transitions the telemetry configuration and metadata management from a remote Firestore dependency to a local file-based caching mechanism. This change enhances the robustness of the CLI by removing reliance on external database services for core functionality, ensuring consistent behavior across different environments and improving performance by reducing network overhead.

Changes:

  • Local Caching Implementation: Replaced Firestore-based dependency for telemetry configuration and metadata with local JSON file caching, improving reliability and reducing external network dependencies.
  • Code Cleanup: Removed Firestore client initialization and associated tools, simplifying the codebase and removing unnecessary dependencies.
  • Enhanced Test Coverage: Added comprehensive tests for local configuration management, including scenarios for new users, existing configurations, and corrupted files.

kadupoornima and others added 9 commits May 1, 2026 05:17
@kadupoornima
base
c9f6867
@kadupoornima
add
5a44185
@kadupoornima
modules
933c211
@kadupoornima
examples
c8ed6ff
@kadupoornima
refactor
c723b24
@kadupoornima
.
6ad1dd4
@kadupoornima @gemini-code-assist
Update pkg/config/config.go
7b5300a 
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
@kadupoornima
.
ba27f77
@kadupoornima
base
26f442f
@kadupoornima kadupoornima added the release-improvements Added to release notes under the "Improvements" heading. label May 4, 2026
@gemini-code-assist

gemini-code-assist Bot commented May 4, 2026

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request transitions the telemetry configuration and metadata management from a remote Firestore dependency to a local file-based caching mechanism. This change enhances the robustness of the CLI by removing reliance on external database services for core functionality, ensuring consistent behavior across different environments and improving performance by reducing network overhead.

Highlights

  • Local Caching Implementation: Replaced Firestore-based dependency for telemetry configuration and metadata with local JSON file caching, improving reliability and reducing external network dependencies.
  • Code Cleanup: Removed Firestore client initialization and associated tools, simplifying the codebase and removing unnecessary dependencies.
  • Enhanced Test Coverage: Added comprehensive tests for local configuration management, including scenarios for new users, existing configurations, and corrupted files.
Ignored Files
  • Ignored by pattern: .github/workflows/** (1)
    • .github/workflows/cache-metadata.yml
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

@kadupoornima kadupoornima changed the title [Telemetry] Use local caching for User config of Telemetry preferences [Telemetry] Implement local caching to persistently store user config. Remove Firestore dependency completely May 4, 2026
@kadupoornima kadupoornima marked this pull request as ready for review May 4, 2026 08:41
@kadupoornima kadupoornima requested a review from a team as a code owner May 4, 2026 08:41
gemini-code-assist[bot]
gemini-code-assist Bot reviewed May 4, 2026
View reviewed changes

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request migrates the metadata and telemetry configuration storage from Google Cloud Firestore to a local file-based caching system combined with direct fetching from the GitHub API. Key changes include the introduction of concurrent fetching logic for standard modules and blueprints, the removal of the Firestore dependency from the Go modules, and the implementation of local JSON storage for user telemetry preferences. Feedback focuses on resolving a missing import for YAML parsing, improving the robustness of GitHub API requests by adding a User-Agent header and context timeouts, and ensuring that errors during local cache writes are properly handled rather than ignored.

Comment thread pkg/config/config.go
Comment thread pkg/config/config.go Outdated
Comment thread pkg/config/config.go
SwarnaBharathiMantena
SwarnaBharathiMantena previously approved these changes May 6, 2026
View reviewed changes

@SwarnaBharathiMantena SwarnaBharathiMantena left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kadupoornima kadupoornima enabled auto-merge (squash) May 6, 2026 06:29
@kadupoornima kadupoornima merged commit 7107ddd into GoogleCloudPlatform:develop May 6, 2026
13 of 79 checks passed
@kadupoornima kadupoornima deleted the telemetry-19 branch May 6, 2026 06:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SwarnaBharathiMantena SwarnaBharathiMantena SwarnaBharathiMantena approved these changes

+1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

release-improvements Added to release notes under the "Improvements" heading.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@kadupoornima @SwarnaBharathiMantena