Skip to content

Fix G4 GKE Rapid Version & Add Onboard On-Spot Test Support For Same#5591

Merged
LAVEEN merged 3 commits into
GoogleCloudPlatform:developfrom
LAVEEN:g4gkeonspot
May 4, 2026
Merged

Fix G4 GKE Rapid Version & Add Onboard On-Spot Test Support For Same#5591
LAVEEN merged 3 commits into
GoogleCloudPlatform:developfrom
LAVEEN:g4gkeonspot

Conversation

@LAVEEN

@LAVEEN LAVEEN commented May 3, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

This PR introduces support for deploying G4 machine types on GKE using Spot VMs within the Cluster Toolkit

Submission Checklist

NOTE: Community submissions can take up to 2 weeks to be reviewed.

Please take the following actions before submitting this pull request.

  • Fork your PR branch from the Toolkit "develop" branch (not main)
  • Test all changes with pre-commit in a local branch #
  • Confirm that "make tests" passes all tests
  • Add or modify unit tests to cover code changes
  • Ensure that unit test coverage remains above 80%
  • Update all applicable documentation
  • Follow Cluster Toolkit Contribution guidelines #

laveen and others added 2 commits May 2, 2026 14:04
@gemini-code-assist

gemini-code-assist Bot commented May 3, 2026

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request updates the GKE version used in the G4 example and introduces automated testing infrastructure to support on-spot provisioning scenarios. These changes ensure that the example remains compatible with the latest GKE releases and improve test coverage for spot instance configurations.

Highlights

  • GKE Version Update: Updated the GKE version prefix in the gke-g4 example to 1.35.3-gke.1522000.
  • On-Spot Test Support: Added new cloud build configuration and test variables to support on-spot testing for the GKE G4 example.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

@LAVEEN LAVEEN added the release-chore To not include into release notes label May 3, 2026
gemini-code-assist[bot]
gemini-code-assist Bot reviewed May 3, 2026
View reviewed changes

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the GKE version for the G4 example and introduces a new daily integration test for GKE G4 on Spot instances, including a Cloud Build configuration and associated Ansible variables. Feedback highlights that the PROVISIONING_MODEL variable is referenced without being defined, which will cause logic failures at runtime. Additionally, the ENABLE_SPOT_FALLBACK environment variable is unused and should be removed to maintain code cleanliness.

Comment thread tools/cloud-build/daily-tests/builds/gke-g4-onspot.yaml
Comment thread tools/cloud-build/daily-tests/builds/gke-g4-onspot.yaml
@LAVEEN

LAVEEN commented May 3, 2026

Copy link
Copy Markdown
Collaborator Author

[Success] https://pantheon.corp.google.com/cloud-build/builds;region=global/8707ac35-f705-4162-83e9-d83dd87543e5?e=-13802955&mods=monitoring_api_prod&project=hpc-toolkit-dev

[Success] https://pantheon.corp.google.com/cloud-build/builds;region=global/feaa2141-fdc5-4b78-8739-01856ff15698?e=-13802955&mods=monitoring_api_prod&project=hpc-toolkit-dev

@LAVEEN LAVEEN requested a review from kvenkatachala333 May 4, 2026 08:05
@LAVEEN LAVEEN marked this pull request as ready for review May 4, 2026 10:53
@LAVEEN LAVEEN requested a review from a team as a code owner May 4, 2026 10:53
@LAVEEN LAVEEN merged commit c08df75 into GoogleCloudPlatform:develop May 4, 2026
23 of 83 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AdarshK15 AdarshK15 AdarshK15 approved these changes

@kadupoornima kadupoornima kadupoornima approved these changes

@kvenkatachala333 kvenkatachala333 kvenkatachala333 approved these changes

+1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

release-chore To not include into release notes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@LAVEEN @AdarshK15 @kadupoornima @kvenkatachala333