Skip to content

Introduce Kueue and Jobset controller resources overrides inputs#5581

Merged
SwarnaBharathiMantena merged 7 commits into
GoogleCloudPlatform:developfrom
jamOne-:ct-ss-02-controller-overrides
May 7, 2026
Merged

Introduce Kueue and Jobset controller resources overrides inputs#5581
SwarnaBharathiMantena merged 7 commits into
GoogleCloudPlatform:developfrom
jamOne-:ct-ss-02-controller-overrides

Conversation

@jamOne-

@jamOne- jamOne- commented Apr 30, 2026

Copy link
Copy Markdown
Contributor

Introduce Kueue and Jobset controller resources overrides inputs

These settings will be used for DynamicSlicing.

jamOne- added 6 commits April 29, 2026 11:18
@jamOne-
feat: output required variables in compute modules
28e94a5 
Export enable_slice_controller, machine_type, and accelerator_topology_mode
as outputs from the appropriate modules so they can be consumed by other
modules via blueprint use blocks.
@jamOne-
Revert "feat: output required variables in compute modules"
6f4f4eb 
This reverts commit 28e94a5.
@jamOne-
Introduce Kueue and Jobset controller resources overrides inputs
b985546
@jamOne-
Update Kueue and Jobset overrides to include limits for consistency
5007af2
@jamOne-
Revert unrelated change in main.tf
50db105
@jamOne-
Merge remote-tracking branch 'upstream/develop' into ct-ss-02-control…
2c8b7d3 
…ler-overrides

# Conflicts:
#	modules/management/kubectl-apply/README.md
@jamOne- jamOne- requested a review from a team as a code owner April 30, 2026 11:18
@github-actions github-actions Bot added the external PR from external contributor label Apr 30, 2026
@gemini-code-assist

gemini-code-assist Bot commented Apr 30, 2026

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the kubectl-apply module by introducing new configuration options for the Kueue and Jobset controllers. These additions allow for fine-grained control over the CPU, memory, and replica allocations for these critical Kubernetes components, facilitating advanced use cases such as DynamicSlicing by enabling resource overrides.

Highlights

  • Kueue Controller Resource Overrides: Introduced controller_cpu, controller_memory, and controller_replicas input variables for the Kueue workload scheduler, allowing for fine-grained resource and replica configuration.
  • Jobset Controller Resource Overrides: Added controller_cpu and controller_memory input variables for the Jobset controller, enabling resource request and limit customization.
  • Dynamic Configuration via Helm: Enabled dynamic application of these new resource and replica overrides to Kueue and Jobset controllers through conditional Helm chart values_yaml.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist[bot]
gemini-code-assist Bot reviewed Apr 30, 2026
View reviewed changes

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds configuration options for resource requests, limits, and replicas for the Kueue and Jobset controllers in the kubectl-apply module. The changes include updates to variable definitions, dynamic Helm value generation, and documentation. Review feedback suggests changing the type of the controller_cpu variables from number to any to support standard Kubernetes CPU resource formats, such as millicores (e.g., "500m").

Comment thread modules/management/kubectl-apply/variables.tf Outdated
Comment thread modules/management/kubectl-apply/variables.tf Outdated
@SwarnaBharathiMantena SwarnaBharathiMantena added the release-module-improvements Added to release notes under the "Module Improvements" heading. label Apr 30, 2026
@SwarnaBharathiMantena

SwarnaBharathiMantena commented Apr 30, 2026

Copy link
Copy Markdown
Contributor

/gcbrun

@SwarnaBharathiMantena

SwarnaBharathiMantena commented May 5, 2026

Copy link
Copy Markdown
Contributor

/gcbrun

1 similar comment
@SwarnaBharathiMantena

SwarnaBharathiMantena commented May 6, 2026

Copy link
Copy Markdown
Contributor

/gcbrun

@scaliby

scaliby commented May 7, 2026

Copy link
Copy Markdown
Contributor

@SwarnaBharathiMantena would appreciate your review here. It seems that tests have failed with unrelated reason.

SwarnaBharathiMantena
SwarnaBharathiMantena approved these changes May 7, 2026
View reviewed changes

@SwarnaBharathiMantena SwarnaBharathiMantena left a comment •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

The failing tests are mainly capacity issues. The TPU v6e flex start test is not related to the changes on this PR. The fix will be part of another PR.

@SwarnaBharathiMantena SwarnaBharathiMantena enabled auto-merge (squash) May 7, 2026 15:21
@SwarnaBharathiMantena SwarnaBharathiMantena merged commit c36ee34 into GoogleCloudPlatform:develop May 7, 2026
30 of 83 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SwarnaBharathiMantena SwarnaBharathiMantena SwarnaBharathiMantena approved these changes

@parulbajaj01 parulbajaj01 parulbajaj01 approved these changes

+1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

external PR from external contributor release-module-improvements Added to release notes under the "Module Improvements" heading.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jamOne- @SwarnaBharathiMantena @scaliby @parulbajaj01