Skip to content

minor fix: gcluster job config bug and dynamic slicing references#5580

Merged
Neelabh94 merged 1 commit into
GoogleCloudPlatform:developfrom
Neelabh94:workload_submission
May 4, 2026
Merged

minor fix: gcluster job config bug and dynamic slicing references#5580
Neelabh94 merged 1 commit into
GoogleCloudPlatform:developfrom
Neelabh94:workload_submission

Conversation

@Neelabh94

@Neelabh94 Neelabh94 commented Apr 30, 2026

Copy link
Copy Markdown
Contributor

PR fixes a bug in config setting logic and updates references to dynamic slicing with the correct nomenclature.

Submission Checklist

NOTE: Community submissions can take up to 2 weeks to be reviewed.

Please take the following actions before submitting this pull request.

  • Fork your PR branch from the Toolkit "develop" branch (not main)
  • Test all changes with pre-commit in a local branch #
  • Confirm that "make tests" passes all tests
  • Add or modify unit tests to cover code changes
  • Ensure that unit test coverage remains above 80%
  • Update all applicable documentation
  • Follow Cluster Toolkit Contribution guidelines #

@Neelabh94 Neelabh94 requested a review from a team as a code owner April 30, 2026 08:23
@gemini-code-assist

gemini-code-assist Bot commented Apr 30, 2026

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a functional bug in the gcluster job configuration command and standardizes internal terminology. By modifying the command's execution flow, it ensures that persistent configuration can be managed without mandatory global flags. Additionally, the codebase has been updated to replace legacy 'Super-slicing' references with the accurate 'Dynamic-slicing' nomenclature, ensuring consistency throughout the orchestrator logic.

Highlights

  • Bug Fix in Job Configuration: Updated the 'config' command to override 'PersistentPreRunE', preventing it from incorrectly requiring global flags to be set.
  • Nomenclature Update: Renamed all references of 'Super-slicing' to 'Dynamic-slicing' across the GKE orchestrator codebase to align with correct terminology.
  • Test Coverage: Added a new unit test in 'cmd/job/config_test.go' to verify that the config command functions correctly without requiring global flags.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

@Neelabh94 Neelabh94 added the release-chore To not include into release notes label Apr 30, 2026
gemini-code-assist[bot]
gemini-code-assist Bot reviewed Apr 30, 2026
View reviewed changes

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the config command to operate without global flags and renames 'Super-slicing' to 'Dynamic-slicing' across the GKE orchestrator for terminology alignment. I have no feedback to provide.

SwarnaBharathiMantena
SwarnaBharathiMantena approved these changes May 4, 2026
View reviewed changes

@SwarnaBharathiMantena SwarnaBharathiMantena left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Neelabh94 Neelabh94 merged commit af95d74 into GoogleCloudPlatform:develop May 4, 2026
15 of 75 checks passed
@Neelabh94 Neelabh94 deleted the workload_submission branch May 7, 2026 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SwarnaBharathiMantena SwarnaBharathiMantena SwarnaBharathiMantena approved these changes

+1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@SwarnaBharathiMantena SwarnaBharathiMantena

Labels

release-chore To not include into release notes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Neelabh94 @SwarnaBharathiMantena