Skip to content

adding new module direct-helm-install in community folder.#5578

Merged
arpit974 merged 5 commits into
GoogleCloudPlatform:developfrom
arpit974:community/direct-helm-install-module
May 11, 2026
Merged

adding new module direct-helm-install in community folder.#5578
arpit974 merged 5 commits into
GoogleCloudPlatform:developfrom
arpit974:community/direct-helm-install-module

Conversation

@arpit974

@arpit974 arpit974 commented Apr 30, 2026

Copy link
Copy Markdown
Contributor

Adding a new community module to install Helm charts directly onto a GKE cluster using credentials fetched dynamically from the cluster ID. This avoids requiring pre-configured Kubernetes provider context and enables better automated deployment flows for Helm charts in fresh clusters.

Submission Checklist

NOTE: Community submissions can take up to 2 weeks to be reviewed.

Please take the following actions before submitting this pull request.

  • Fork your PR branch from the Toolkit "develop" branch (not main)
  • Test all changes with pre-commit in a local branch #
  • Confirm that "make tests" passes all tests
  • Add or modify unit tests to cover code changes
  • Ensure that unit test coverage remains above 80%
  • Update all applicable documentation
  • Follow Cluster Toolkit Contribution guidelines #

@gemini-code-assist

gemini-code-assist Bot commented Apr 30, 2026

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a new community module designed to streamline the deployment of Helm charts onto GKE clusters. By dynamically fetching cluster credentials based on a provided cluster ID, the module simplifies the setup process and enables more robust, automated deployment pipelines without requiring manual Kubernetes provider configuration.

Highlights

  • New Module Addition: Added a new community module 'direct-helm-install' to facilitate Helm chart deployments on GKE clusters.
  • Dynamic Configuration: Implemented dynamic credential fetching using 'cluster_id', removing the need for pre-configured Kubernetes provider contexts.
  • Improved Automation: Enhanced support for automated deployment workflows in fresh clusters by integrating Helm provider configuration directly into the module.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

@arpit974 arpit974 added the release-new-modules Added to release notes under the "New Modules" heading. label Apr 30, 2026
gemini-code-assist[bot]
gemini-code-assist Bot reviewed Apr 30, 2026
View reviewed changes

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a new community module, direct-helm-install, which allows for direct Helm chart deployments to GKE clusters by fetching credentials dynamically. The review feedback suggests several improvements: registering the module in the project's main index, making the cluster_id variable required, updating documentation examples to use the use block for dependencies, avoiding the internal provider block anti-pattern, and relaxing the Terraform version constraint for better compatibility.

Comment thread community/modules/management/direct-helm-install/README.md
Comment thread community/modules/management/direct-helm-install/variables.tf
Comment thread community/modules/management/direct-helm-install/README.md Outdated
Comment thread community/modules/management/direct-helm-install/main.tf
Comment thread community/modules/management/direct-helm-install/versions.tf
@arpit974 arpit974 marked this pull request as ready for review April 30, 2026 10:53
@arpit974 arpit974 requested a review from a team as a code owner April 30, 2026 10:53
kvenkatachala333
kvenkatachala333 approved these changes May 5, 2026
View reviewed changes

@kvenkatachala333 kvenkatachala333 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just a minor nit: please handle the gemini suggestion of ensuring new module is added to the index in the root modules/README.md file as required by the repository style guide

@arpit974 arpit974 merged commit 5b7afc5 into GoogleCloudPlatform:develop May 11, 2026
17 of 77 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kvenkatachala333 kvenkatachala333 kvenkatachala333 approved these changes

+1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

release-new-modules Added to release notes under the "New Modules" heading.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@arpit974 @kvenkatachala333