Skip to content

chore: align Batch blueprints with org-wide naming convention#5568

Merged
Neelabh94 merged 1 commit into
GoogleCloudPlatform:developfrom
Neelabh94:batch-blueprint-fix
Apr 30, 2026
Merged

chore: align Batch blueprints with org-wide naming convention#5568
Neelabh94 merged 1 commit into
GoogleCloudPlatform:developfrom
Neelabh94:batch-blueprint-fix

Conversation

@Neelabh94

@Neelabh94 Neelabh94 commented Apr 29, 2026

Copy link
Copy Markdown
Contributor

This PR removes references to "serverless" and "cloud-batch" from Google Cloud Batch blueprints, documentation, and tests. These changes are intended to align the Toolkit with the organization-wide naming convention for the Batch product.

Key Changes

Blueprints & Examples:

  • Renamed examples/serverless-batch.yaml to examples/batch.yaml.
  • Renamed examples/serverless-batch-mpi.yaml to examples/batch-mpi.yaml.
  • Updated examples/README.md to reflect these renames and updated anchor links.

Documentation:

  • Renamed docs/cloud-batch.md to docs/batch.md.
  • Updated modules/scheduler/batch-job-template/README.md to reference the new example paths.

Modules:

  • Updated modules/scheduler/batch-job-template/variables.tf to modify the default job_filename description.

Tests:

  • Renamed and updated Cloud Build daily test configurations (builds and test YAMLs) to use the "batch" naming scheme.

Submission Checklist

NOTE: Community submissions can take up to 2 weeks to be reviewed.

Please take the following actions before submitting this pull request.

  • Fork your PR branch from the Toolkit "develop" branch (not main)
  • Test all changes with pre-commit in a local branch #
  • Confirm that "make tests" passes all tests
  • Add or modify unit tests to cover code changes
  • Ensure that unit test coverage remains above 80%
  • Update all applicable documentation
  • Follow Cluster Toolkit Contribution guidelines #

@gemini-code-assist

gemini-code-assist Bot commented Apr 29, 2026

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request updates the naming conventions for Google Cloud Batch components within the Toolkit. By removing 'serverless' and 'cloud' prefixes from blueprints, documentation, and test configurations, the project achieves better consistency with the official product naming. These changes ensure that all references, paths, and test definitions are aligned with the new standard.

Highlights

  • Naming Convention Alignment: Renamed various files, blueprints, and documentation references from 'serverless-batch' and 'cloud-batch' to simply 'batch' to align with organization-wide naming standards.
  • Documentation Updates: Updated README files and documentation pages to reflect the new naming scheme and updated anchor links.
  • Test Configuration Updates: Renamed and updated Cloud Build daily test configurations and YAML files to ensure consistency with the new naming convention.
  • Module Configuration: Updated the default job_filename description in the batch-job-template module to match the new naming.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist[bot]
gemini-code-assist Bot reviewed Apr 29, 2026
View reviewed changes

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request renames 'serverless-batch' to 'batch' and 'serverless-batch-mpi' to 'batch-mpi' across documentation, example blueprints, and test configurations. Additionally, it updates the default filename for generated batch job templates from cloud-batch-<job_id>.json to <job_id>.yaml in the module's variable descriptions and README. I have no feedback to provide.

gemini-code-assist[bot]
gemini-code-assist Bot reviewed Apr 29, 2026
View reviewed changes

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request renames the serverless batch examples and blueprints to a more concise "batch" naming convention across documentation, example files, and CI/CD configurations. It also updates the default file extension for generated batch job templates from .json to .yaml in the module documentation and variable definitions. I have no feedback to provide.

@Neelabh94 Neelabh94 force-pushed the batch-blueprint-fix branch from 1fb9498 to 4c08075 Compare April 29, 2026 05:00
@Neelabh94

Neelabh94 commented Apr 29, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

PR test for batch (earlier cloud-batch): https://pantheon.corp.google.com/cloud-build/builds/1df7ff60-c44f-4f1e-97bd-13e08274952b?project=hpc-toolkit-dev

PR-test-batch-mpi results: https://pantheon.corp.google.com/cloud-build/builds;region=global/b2edc025-3e3c-43db-a536-a9815411f9f4?project=hpc-toolkit-dev

@Neelabh94 Neelabh94 marked this pull request as ready for review April 29, 2026 05:33
@Neelabh94 Neelabh94 requested a review from a team as a code owner April 29, 2026 05:33
@Neelabh94 Neelabh94 added documentation Improvements or additions to documentation release-chore To not include into release notes labels Apr 29, 2026
@Neelabh94 Neelabh94 merged commit 79e93d6 into GoogleCloudPlatform:develop Apr 30, 2026
16 of 77 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@arpit974 arpit974 arpit974 approved these changes

+1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

documentation Improvements or additions to documentation release-chore To not include into release notes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Neelabh94 @arpit974