Skip to content

Update GKE TPU examples by removing static_node_count var#5557

Merged
agrawalkhushi18 merged 5 commits into
GoogleCloudPlatform:developfrom
agrawalkhushi18:tpu-node-count
Apr 29, 2026
Merged

Update GKE TPU examples by removing static_node_count var#5557
agrawalkhushi18 merged 5 commits into
GoogleCloudPlatform:developfrom
agrawalkhushi18:tpu-node-count

Conversation

@agrawalkhushi18

@agrawalkhushi18 agrawalkhushi18 commented Apr 27, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

1. Rationale

This PR eliminatesstatic_node_count variable from TPU example blueprints as the node count value is automatically getting derived from machine_type, tpu_topology, and num_slices. This reduces deployment errors and simplifies the user experience.

2. Changes Done

  • Removed static_node_count variable from YAML files
  • Updated all references to use auto-calculated node_count_static from the GKE module
  • Updated README documentation to clarify automatic calculation and removed manual calculation examples

Submission Checklist

NOTE: Community submissions can take up to 2 weeks to be reviewed.

Please take the following actions before submitting this pull request.

  • Fork your PR branch from the Toolkit "develop" branch (not main)
  • Test all changes with pre-commit in a local branch #
  • Confirm that "make tests" passes all tests
  • Add or modify unit tests to cover code changes
  • Ensure that unit test coverage remains above 80%
  • Update all applicable documentation
  • Follow Cluster Toolkit Contribution guidelines #

@gemini-code-assist

gemini-code-assist Bot commented Apr 27, 2026

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refactors the GKE TPU configuration to improve consistency and reduce redundancy. By removing an unused variable and updating the quota calculation logic to reference the node pool's internal state, the configuration becomes more robust and easier to maintain.

Highlights

  • Configuration Cleanup: Removed the redundant static_node_count variable from the GKE TPU configuration.
  • Logic Update: Updated the tpu_quota calculation to use the node_count_static property directly from the node pool definition instead of a global variable.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

@agrawalkhushi18 agrawalkhushi18 added the release-chore To not include into release notes label Apr 27, 2026
gemini-code-assist[bot]
gemini-code-assist Bot reviewed Apr 27, 2026
View reviewed changes

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes the static_node_count variable from the blueprint and updates the tpu_quota calculation to reference an output from the gke-tpu-7x-pool module. Review feedback highlights two critical issues: first, removing the explicit node count may cause deployment failures if the module logic for automatic calculation is missing; second, the updated tpu_quota calculation will likely fail because it attempts to perform arithmetic on a list output (resulting from the module's use of count) without proper indexing.

Comment thread examples/gke-tpu-7x/gke-tpu-7x.yaml
Comment thread examples/gke-tpu-7x/gke-tpu-7x.yaml
@agrawalkhushi18 agrawalkhushi18 marked this pull request as ready for review April 28, 2026 10:15
@agrawalkhushi18 agrawalkhushi18 requested a review from a team as a code owner April 28, 2026 10:15
shubpal07
shubpal07 approved these changes Apr 28, 2026
View reviewed changes

@shubpal07 shubpal07 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!
Automating static_node_count from topology and machine type reduces configuration complexity and prevents deployment failures due to manual calculation errors.

SwarnaBharathiMantena
SwarnaBharathiMantena approved these changes Apr 28, 2026
View reviewed changes

@SwarnaBharathiMantena SwarnaBharathiMantena left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@agrawalkhushi18 agrawalkhushi18 changed the title (gke)Check automated static_node_count for TPU Update GKE TPU examples by removing static_node_count var Apr 29, 2026
@agrawalkhushi18 agrawalkhushi18 merged commit 4e9329e into GoogleCloudPlatform:develop Apr 29, 2026
25 of 84 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SwarnaBharathiMantena SwarnaBharathiMantena SwarnaBharathiMantena approved these changes

@shubpal07 shubpal07 shubpal07 approved these changes

+1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

release-chore To not include into release notes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@agrawalkhushi18 @SwarnaBharathiMantena @shubpal07