[Telemetry] Add support to identify if user is internal or external#5503
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces functionality to distinguish between internal and external users within the telemetry data. By detecting specific Google-related account configurations and developer tools, the system can now tag events with an 'IsGoogler' flag, enabling better analysis of tool usage patterns across different user segments. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request introduces a mechanism to identify internal Google users by checking the active gcloud account and the presence of internal developer tools. The review feedback suggests optimizing the check order for better performance and adding the --quiet flag to the gcloud command to prevent potential execution hangs.
|
/gemini summary |
Summary of ChangesThis pull request introduces functionality to distinguish between internal and external users within the telemetry data. By detecting specific Google-related account configurations and developer tools, the system can now tag events with an 'IsGoogler' flag, enabling better analysis of tool usage patterns across different user segments. Highlights
Activity
|
|
/gemini summary |
|
/gemini review |
Summary of ChangesThis pull request enhances the Cluster Toolkit Telemetry system by introducing functionality to distinguish between internal and external users. By detecting specific Google-related account configurations and developer tools, the system can now tag events with an 'IsGoogler' flag, enabling better analysis of tool usage patterns across different user segments. Highlights
Activity
|
There was a problem hiding this comment.
Code Review
This pull request introduces a mechanism to identify internal Google users and service accounts for telemetry purposes. It implements checks for Application Default Credentials and falls back to the gcloud CLI to determine the authenticated account. Feedback focuses on improving performance and reliability by checking for internal developer binaries before spawning external processes, implementing timeouts for shell commands, and optimizing email domain verification by replacing inefficient regex matching with string suffix checks.
SwarnaBharathiMantena
left a comment
There was a problem hiding this comment.
LGTM!
Discussed offline about service accounts to consider as internal users.
ad06168
into
GoogleCloudPlatform:develop
This pull request enhances the Cluster Toolkit Telemetry system by introducing functionality to distinguish between internal and external users. By detecting specific Google-related account configurations and developer tools, the system can now tag events with an
IsGooglerflag, enabling better analysis of tool usage patterns across different user segments.Changes:
IsGooglerboolean field to the concord event in telemetry to identify if the user is an internal Google user or not.@google.comgcloud accounts and the presence of internal developer binaries.KINDLY NOTE THAT TELEMETRY DATA IS NOT BEING COLLECTED YET.