Skip to content

Missing GCLUSTER_GCS_PATH env variable in slurm-rapid-storage#5446

Merged
aslam-quad merged 1 commit into
GoogleCloudPlatform:developfrom
aslam-quad:secret-env-gcluster-path
Apr 2, 2026
Merged

Missing GCLUSTER_GCS_PATH env variable in slurm-rapid-storage#5446
aslam-quad merged 1 commit into
GoogleCloudPlatform:developfrom
aslam-quad:secret-env-gcluster-path

Conversation

@aslam-quad

@aslam-quad aslam-quad commented Apr 2, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Missing GCLUSTER_GCS_PATH env variable
slurm-rapid-storage

Submission Checklist

NOTE: Community submissions can take up to 2 weeks to be reviewed.

Please take the following actions before submitting this pull request.

  • Fork your PR branch from the Toolkit "develop" branch (not main)
  • Test all changes with pre-commit in a local branch #
  • Confirm that "make tests" passes all tests
  • Add or modify unit tests to cover code changes
  • Ensure that unit test coverage remains above 80%
  • Update all applicable documentation
  • Follow Cluster Toolkit Contribution guidelines #

@gemini-code-assist

gemini-code-assist Bot commented Apr 2, 2026

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a missing environment variable dependency required for the slurm-rapid-storage build process. By configuring the necessary secret retrieval, the build pipeline can now correctly access the required GCS path, ensuring proper execution of the integration tests.

Highlights

  • Environment Variable Configuration: Added the missing GCLUSTER_GCS_PATH environment variable to the build configuration.
  • Secret Management: Integrated Secret Manager to securely retrieve and inject the GCLUSTER_GCS_PATH value into the build environment.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

@github-actions github-actions Bot added the external PR from external contributor label Apr 2, 2026
gemini-code-assist[bot]
gemini-code-assist Bot reviewed Apr 2, 2026
View reviewed changes

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the slurm-rapid-storage.yaml Cloud Build configuration to integrate with Google Cloud Secret Manager. It adds the GCLUSTER_GCS_PATH environment variable, sourced from the gcluster-develop-release-bucket secret, to the build steps. I have no feedback to provide as there were no review comments to evaluate.

@aslam-quad aslam-quad changed the title Missing GCLUSTER_GCS_PATH env variable Missing GCLUSTER_GCS_PATH env variable in slurm-rapid-storage Apr 2, 2026
@aslam-quad aslam-quad force-pushed the secret-env-gcluster-path branch from e1dc28c to 289cb5c Compare April 2, 2026 04:33
@aslam-quad aslam-quad marked this pull request as ready for review April 2, 2026 04:47
@aslam-quad aslam-quad requested review from a team and samskillman as code owners April 2, 2026 04:47
@aslam-quad aslam-quad added the release-chore To not include into release notes label Apr 2, 2026
@aslam-quad aslam-quad merged commit f661b3a into GoogleCloudPlatform:develop Apr 2, 2026
14 of 86 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Neelabh94 Neelabh94 Neelabh94 approved these changes

@arpit974 arpit974 arpit974 approved these changes

@samskillman samskillman Awaiting requested review from samskillman

@vikramvs-gg vikramvs-gg Awaiting requested review from vikramvs-gg

+1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

external PR from external contributor release-chore To not include into release notes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@aslam-quad @Neelabh94 @arpit974