Skip to content

pin images to version v20260210#5419

Merged
kvenkatachala333 merged 1 commit into
GoogleCloudPlatform:developfrom
kvenkatachala333:image_pinning
Mar 30, 2026
Merged

pin images to version v20260210#5419
kvenkatachala333 merged 1 commit into
GoogleCloudPlatform:developfrom
kvenkatachala333:image_pinning

Conversation

@kvenkatachala333

@kvenkatachala333 kvenkatachala333 commented Mar 27, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

Image pinning was taken care for a3mega-slurm-gcsfuse-lssd-blueprint.yaml as well as a3ultra-vm.yaml to ubuntu-accelerator-2204-amd64-with-nvidia-570-v20260210

@gemini-code-assist

gemini-code-assist Bot commented Mar 27, 2026

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request updates the machine learning blueprints to pin specific VM images. By moving from image families to explicit versioned image names, the deployment process gains better predictability and stability across infrastructure provisioning.

Highlights

  • Image Pinning: Updated base image configurations to use specific versioned images instead of image families to ensure environment consistency.
  • Configuration Refactoring: Restructured variable definitions in the A3 Mega blueprint to support the new base image schema.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist[bot]
gemini-code-assist Bot reviewed Mar 27, 2026
View reviewed changes

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the base image configuration in the A3 Mega and A3 Ultra machine learning examples to use a specific versioned image (v20260210) instead of an image family. The review feedback points out that hardcoding this specific version string in multiple files creates a maintenance burden and potential for the examples to fall out of sync. It is recommended to use a shared variable if the project structure allows, or at minimum, add comments to both files referencing the dependency to ensure they are updated together in the future.

Comment thread examples/machine-learning/a3-megagpu-8g/a3mega-slurm-gcsfuse-lssd-blueprint.yaml
Comment thread examples/machine-learning/a3-ultragpu-8g/a3ultra-vm.yaml
@kvenkatachala333 kvenkatachala333 changed the title pinning image pin images to version v20260210 Mar 28, 2026
arpit974
arpit974 approved these changes Mar 30, 2026
View reviewed changes

@arpit974 arpit974 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please make sure, relevant tests are run successfully.

@kvenkatachala333 kvenkatachala333 marked this pull request as ready for review March 30, 2026 04:41
@kvenkatachala333 kvenkatachala333 requested review from a team and samskillman as code owners March 30, 2026 04:41
@kvenkatachala333 kvenkatachala333 added the release-chore To not include into release notes label Mar 30, 2026
@kvenkatachala333 kvenkatachala333 merged commit b5fec32 into GoogleCloudPlatform:develop Mar 30, 2026
20 of 81 checks passed
@kvenkatachala333 kvenkatachala333 deleted the image_pinning branch March 30, 2026 04:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@arpit974 arpit974 arpit974 approved these changes

@samskillman samskillman Awaiting requested review from samskillman

+1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

release-chore To not include into release notes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@kvenkatachala333 @arpit974