Skip to content

Merge V1.85.0 into Develop#5398

Merged
aslam-quad merged 7 commits into
developfrom
main
Mar 25, 2026
Merged

Merge V1.85.0 into Develop#5398
aslam-quad merged 7 commits into
developfrom
main

Conversation

@siddhartha-quad

@siddhartha-quad siddhartha-quad commented Mar 25, 2026

Copy link
Copy Markdown
Contributor

Merge V1.85.0 into Develop

Submission Checklist

NOTE: Community submissions can take up to 2 weeks to be reviewed.

Please take the following actions before submitting this pull request.

  • Fork your PR branch from the Toolkit "develop" branch (not main)
  • Test all changes with pre-commit in a local branch #
  • Confirm that "make tests" passes all tests
  • Add or modify unit tests to cover code changes
  • Ensure that unit test coverage remains above 80%
  • Update all applicable documentation
  • Follow Cluster Toolkit Contribution guidelines #

@siddhartha-quad siddhartha-quad requested review from a team and samskillman as code owners March 25, 2026 08:38
@github-actions github-actions Bot added the external PR from external contributor label Mar 25, 2026
@siddhartha-quad siddhartha-quad added the release-chore To not include into release notes label Mar 25, 2026
@gemini-code-assist

gemini-code-assist Bot commented Mar 25, 2026

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request primarily focuses on updating the project to version v1.85.0. It introduces enhanced documentation for pre-built bundles to support multi-architecture downloads (amd64 and arm64) and includes a critical security enhancement to safeguard against Zip Slip vulnerabilities during file extraction. All Terraform modules have also been version-bumped to align with this new release.

Highlights

  • Version Update: The project version has been updated to v1.85.0 across the application and all associated Terraform modules.
  • Multi-Architecture Bundle Support: The README.md has been updated to reflect new multi-architecture bundle naming conventions (e.g., including amd64 or arm64) and provides distinct download instructions for different versions.
  • Security Enhancement: A security fix was implemented in the downloader.go to prevent path traversal vulnerabilities (Zip Slip) during archive extraction.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist[bot]
gemini-code-assist Bot reviewed Mar 25, 2026
View reviewed changes

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the project version to v1.85.0, affecting the gcluster binary and numerous Terraform modules. The README.md has been updated to reflect multi-architecture bundle support (amd64/arm64) for v1.85.0 and newer, with separate instructions for older versions. A security enhancement was implemented in downloader.go to prevent Zip Slip vulnerabilities during binary extraction. Review feedback suggests improving maintainability by centralizing the hardcoded version strings in Terraform modules.

Comment thread community/modules/compute/gke-nodeset/versions.tf
@aslam-quad aslam-quad merged commit 7d82252 into develop Mar 25, 2026
19 of 82 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Neelabh94 Neelabh94 Neelabh94 approved these changes

@vikramvs-gg vikramvs-gg vikramvs-gg approved these changes

@samskillman samskillman Awaiting requested review from samskillman

+1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

external PR from external contributor release-chore To not include into release notes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@siddhartha-quad @Neelabh94 @vikramvs-gg @aslam-quad @LAVEEN @kvenkatachala333