Skip to content

Refine gcluster deploy flag checks to only consider local flags.#5372

Merged
Neelabh94 merged 1 commit into
GoogleCloudPlatform:developfrom
scaliby:enable-global-flags-on-deploy
Mar 21, 2026
Merged

Refine gcluster deploy flag checks to only consider local flags.#5372
Neelabh94 merged 1 commit into
GoogleCloudPlatform:developfrom
scaliby:enable-global-flags-on-deploy

Conversation

@scaliby

@scaliby scaliby commented Mar 19, 2026

Copy link
Copy Markdown
Contributor

Submission Checklist

Running gcluster deploy <DEPLOYMENT> --download-dependencies fails. This change fixes this so we are supporting global flags for that command.

@scaliby scaliby requested review from a team and samskillman as code owners March 19, 2026 11:15
@scaliby scaliby changed the title fix: enable global flags on gcluster deploy Enable global flags on gcluster deploy Mar 19, 2026
@github-actions github-actions Bot added the external PR from external contributor label Mar 19, 2026
@gemini-code-assist

gemini-code-assist Bot commented Mar 19, 2026

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request resolves a bug in the gcluster deploy command where global flags were not being correctly recognized, leading to failures when using commands like gcluster deploy <DEPLOYMENT> --download-dependencies. The change updates the flag checking mechanism to properly differentiate between local and global flags, restoring the expected functionality for command-line operations.

Highlights

  • Fix gcluster deploy command: Enabled support for global flags, specifically addressing an issue where gcluster deploy <DEPLOYMENT> --download-dependencies was failing due to incorrect flag checking.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist[bot]
gemini-code-assist Bot reviewed Mar 19, 2026
View reviewed changes

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request addresses a bug where global flags were incorrectly rejected when using gcluster deploy with a deployment directory. The change from createCmd.Flag() to createCmd.LocalFlags().Lookup() correctly distinguishes between flags local to the create command and global persistent flags. This ensures that only flags specific to creation are disallowed, while global flags are permitted. The fix is correct and well-targeted.

@SwarnaBharathiMantena SwarnaBharathiMantena added the release-bugfix Added to release notes under the "Bug fixes" heading. label Mar 20, 2026
@scaliby scaliby changed the title Enable global flags on gcluster deploy Refine gcluster deploy flag checks to only consider local flags. Mar 20, 2026
@Neelabh94

Neelabh94 commented Mar 20, 2026

Copy link
Copy Markdown
Contributor

/gcbrun

SwarnaBharathiMantena
SwarnaBharathiMantena approved these changes Mar 20, 2026
View reviewed changes

@SwarnaBharathiMantena SwarnaBharathiMantena left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@scaliby

scaliby commented Mar 20, 2026

Copy link
Copy Markdown
Contributor Author

@Neelabh94 could you please approve?

@Neelabh94 Neelabh94 merged commit dd5375a into GoogleCloudPlatform:develop Mar 21, 2026
20 of 83 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Neelabh94 Neelabh94 Neelabh94 approved these changes

@SwarnaBharathiMantena SwarnaBharathiMantena SwarnaBharathiMantena approved these changes

@samskillman samskillman Awaiting requested review from samskillman

+1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

external PR from external contributor release-bugfix Added to release notes under the "Bug fixes" heading.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@scaliby @Neelabh94 @SwarnaBharathiMantena