Skip to content

Added pfs-managed-lustre-slurm readme#5362

Merged
aslam-quad merged 2 commits into
GoogleCloudPlatform:developfrom
siddhartha-quad:pfs-manages-lustre-slurm-readme
Mar 31, 2026
Merged

Added pfs-managed-lustre-slurm readme#5362
aslam-quad merged 2 commits into
GoogleCloudPlatform:developfrom
siddhartha-quad:pfs-manages-lustre-slurm-readme

Conversation

@siddhartha-quad

@siddhartha-quad siddhartha-quad commented Mar 16, 2026

Copy link
Copy Markdown
Contributor

This PR adds pfs-managed-lustre-slurm instructions in index readme

Submission Checklist

NOTE: Community submissions can take up to 2 weeks to be reviewed.

Please take the following actions before submitting this pull request.

  • Fork your PR branch from the Toolkit "develop" branch (not main)
  • Test all changes with pre-commit in a local branch #
  • Confirm that "make tests" passes all tests
  • Add or modify unit tests to cover code changes
  • Ensure that unit test coverage remains above 80%
  • Update all applicable documentation
  • Follow Cluster Toolkit Contribution guidelines #

@siddhartha-quad siddhartha-quad requested review from a team and samskillman as code owners March 16, 2026 10:32
@github-actions github-actions Bot added the external PR from external contributor label Mar 16, 2026
@gemini-code-assist

gemini-code-assist Bot commented Mar 16, 2026

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request expands the documentation within the HPC Toolkit by integrating a new guide for deploying a high-performance compute cluster. The added content focuses on a blueprint that combines the Slurm Workload Manager with Google Cloud Managed Service for Lustre, aiming to provide users with clear instructions for setting up such an environment.

Highlights

  • Documentation for pfs-managed-lustre-slurm: Added a new section to the examples/README.md file, providing comprehensive instructions and details for the pfs-managed-lustre-slurm blueprint. This includes its purpose, integration with Slurm and Managed Lustre, and commands for provisioning and destroying the cluster.
  • README Table of Contents Update: Included a new entry for pfs-managed-lustre-slurm.yaml in the table of contents of examples/README.md to ensure discoverability of the new documentation.
Changelog
  • examples/README.md
    • Added a new table of contents entry for pfs-managed-lustre-slurm.yaml.
    • Included a detailed section describing the pfs-managed-lustre-slurm blueprint, its functionality, and deployment commands.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

@siddhartha-quad siddhartha-quad added the release-chore To not include into release notes label Mar 16, 2026
gemini-code-assist[bot]
gemini-code-assist Bot reviewed Mar 16, 2026
View reviewed changes

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds documentation for the new pfs-managed-lustre-slurm.yaml example. The changes are good, but I have a few suggestions to improve the clarity and consistency of the instructions, particularly around the deployment and destruction commands. I've also pointed out a minor grammatical issue.

Comment thread examples/README.md Outdated
Comment thread examples/README.md Outdated
Comment thread examples/README.md Outdated
@siddhartha-quad siddhartha-quad force-pushed the pfs-manages-lustre-slurm-readme branch 2 times, most recently from 636fe7e to e723e56 Compare March 16, 2026 11:47
vikramvs-gg
vikramvs-gg reviewed Mar 25, 2026
View reviewed changes
Comment thread examples/README.md Outdated
@siddhartha-quad siddhartha-quad force-pushed the pfs-manages-lustre-slurm-readme branch from 2589718 to f23107f Compare March 27, 2026 06:31
@aslam-quad aslam-quad merged commit 196c1f1 into GoogleCloudPlatform:develop Mar 31, 2026
13 of 72 checks passed
@siddhartha-quad siddhartha-quad deleted the pfs-manages-lustre-slurm-readme branch April 7, 2026 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@arpit974 arpit974 arpit974 approved these changes

@vikramvs-gg vikramvs-gg vikramvs-gg approved these changes

@samskillman samskillman Awaiting requested review from samskillman

@SwarnaBharathiMantena SwarnaBharathiMantena Awaiting requested review from SwarnaBharathiMantena

+1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

external PR from external contributor release-chore To not include into release notes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@siddhartha-quad @arpit974 @vikramvs-gg @aslam-quad