Skip to content

use constant for google provider version in Go files#5361

Merged
aslam-quad merged 2 commits into
GoogleCloudPlatform:developfrom
aslam-quad:update-terraform-provider-version
Mar 16, 2026
Merged

use constant for google provider version in Go files#5361
aslam-quad merged 2 commits into
GoogleCloudPlatform:developfrom
aslam-quad:update-terraform-provider-version

Conversation

@aslam-quad

@aslam-quad aslam-quad commented Mar 16, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

This change refactors the code to use a constant for the Google terraform provider version

Submission Checklist

NOTE: Community submissions can take up to 2 weeks to be reviewed.

Please take the following actions before submitting this pull request.

  • Fork your PR branch from the Toolkit "develop" branch (not main)
  • Test all changes with pre-commit in a local branch #
  • Confirm that "make tests" passes all tests
  • Add or modify unit tests to cover code changes
  • Ensure that unit test coverage remains above 80%
  • Update all applicable documentation
  • Follow Cluster Toolkit Contribution guidelines #

@aslam-quad aslam-quad requested review from a team and samskillman as code owners March 16, 2026 04:16
@gemini-code-assist

gemini-code-assist Bot commented Mar 16, 2026

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request aims to improve code maintainability and consistency by centralizing the definition of the Google Terraform provider version. By introducing a dedicated constant, the acceptable version range is now defined in a single location, making it easier to update and ensuring that all relevant parts of the codebase use the same version constraint.

Highlights

  • New Constant for Google Provider Version: A new constant, GoogleProviderVersion, was introduced in pkg/config/expand.go to centralize the definition of the acceptable version range for Google Terraform providers.
  • Consistent Provider Version Usage: Hardcoded Google provider version strings in pkg/config/expand.go and pkg/config/expand_test.go were replaced with the newly defined GoogleProviderVersion constant, ensuring consistency and simplifying future updates.
Changelog
  • pkg/config/expand.go
    • Added GoogleProviderVersion constant with version range ">= 6.9.0, <= 7.23.0".
    • Updated getDefaultGoogleProviders function to use GoogleProviderVersion for both "google" and "google-beta" providers.
  • pkg/config/expand_test.go
    • Modified TestExpandProviders to use GoogleProviderVersion in expected TerraformProvider versions for "google" and "google-beta".
Activity
  • No human activity has been recorded on this pull request yet.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

@github-actions github-actions Bot added the external PR from external contributor label Mar 16, 2026
gemini-code-assist[bot]
gemini-code-assist Bot reviewed Mar 16, 2026
View reviewed changes

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors the hardcoded Google provider version string into a constant, which improves maintainability. However, this change also quietly updates the provider version constraint from <= 7.21.0 to <= 7.23.0. This functional change should be clearly communicated in the pull request description to avoid confusion and to maintain a clear history of changes, as per the repository's contribution guidelines.

Comment thread pkg/config/expand.go
@aslam-quad aslam-quad added the release-chore To not include into release notes label Mar 16, 2026
@aslam-quad aslam-quad requested a review from Neelabh94 March 16, 2026 06:00
@aslam-quad aslam-quad merged commit f44cdd5 into GoogleCloudPlatform:develop Mar 16, 2026
16 of 84 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Neelabh94 Neelabh94 Neelabh94 approved these changes

@kvenkatachala333 kvenkatachala333 kvenkatachala333 approved these changes

@samskillman samskillman Awaiting requested review from samskillman

+1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

external PR from external contributor release-chore To not include into release notes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@aslam-quad @Neelabh94 @kvenkatachala333