Skip to content

Remove redundant build files#5339

Merged
sudheer-quad merged 1 commit into
GoogleCloudPlatform:developfrom
sudheer-quad:cleanup-build-files
Mar 13, 2026
Merged

Remove redundant build files#5339
sudheer-quad merged 1 commit into
GoogleCloudPlatform:developfrom
sudheer-quad:cleanup-build-files

Conversation

@sudheer-quad

@sudheer-quad sudheer-quad commented Mar 11, 2026

Copy link
Copy Markdown
Contributor

This PR removes the redundant build files that have been superseded by the new on-spot configuration.

Submission Checklist

NOTE: Community submissions can take up to 2 weeks to be reviewed.

Please take the following actions before submitting this pull request.

  • Fork your PR branch from the Toolkit "develop" branch (not main)
  • Test all changes with pre-commit in a local branch #
  • Confirm that "make tests" passes all tests
  • Add or modify unit tests to cover code changes
  • Ensure that unit test coverage remains above 80%
  • Update all applicable documentation
  • Follow Cluster Toolkit Contribution guidelines #

@sudheer-quad sudheer-quad requested review from a team and samskillman as code owners March 11, 2026 11:45
@github-actions github-actions Bot added the external PR from external contributor label Mar 11, 2026
@sudheer-quad sudheer-quad added the release-chore To not include into release notes label Mar 11, 2026
@gemini-code-assist

gemini-code-assist Bot commented Mar 11, 2026

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request streamlines the project's build infrastructure by removing outdated Cloud Build configurations and their corresponding test definitions. These files, previously essential for daily testing of various GKE and machine learning environments, are no longer required due to the implementation of a new, more efficient on-spot configuration. The cleanup reduces repository clutter and simplifies future maintenance of the build system.

Highlights

  • Redundant Build File Removal: Removed several Cloud Build configuration files that were used for daily tests, as they have been superseded by a new on-spot configuration.
  • GKE Test Configurations: Eliminated specific Cloud Build configurations and associated test YAML files for GKE A2 HighGPU Kueue and GKE A4 environments.
  • ML Test Configurations: Removed the Cloud Build configuration and test YAML file for ML A4 HighGPU Slurm daily tests.
Changelog
  • tools/cloud-build/daily-tests/builds/gke-a2-highgpu-kueue.yaml
    • Removed the Cloud Build configuration for GKE A2 HighGPU Kueue daily tests.
  • tools/cloud-build/daily-tests/builds/gke-a4.yaml
    • Removed the Cloud Build configuration for GKE A4 daily tests.
  • tools/cloud-build/daily-tests/builds/ml-a4-highgpu-slurm.yaml
    • Removed the Cloud Build configuration for ML A4 HighGPU Slurm daily tests.
  • tools/cloud-build/daily-tests/tests/gke-a2-highgpu-kueue.yml
    • Removed the test configuration for GKE A2 HighGPU Kueue.
  • tools/cloud-build/daily-tests/tests/gke-a4.yml
    • Removed the test configuration for GKE A4.
  • tools/cloud-build/daily-tests/tests/ml-a4-highgpu-slurm.yml
    • Removed the test configuration for ML A4 HighGPU Slurm.
Activity
  • The pull request was created by sudheer-quad with the stated purpose of removing redundant build files that have been superseded by a new on-spot configuration.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist[bot]
gemini-code-assist Bot reviewed Mar 11, 2026
View reviewed changes

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes six YAML files related to daily test builds and their configurations. The description states these files are redundant and have been superseded by a new configuration. The changes consist entirely of file deletions. As this appears to be a cleanup of obsolete files, I have not identified any issues with this change.

@sudheer-quad sudheer-quad merged commit b62b016 into GoogleCloudPlatform:develop Mar 13, 2026
12 of 81 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Neelabh94 Neelabh94 Neelabh94 approved these changes

@agrawalkhushi18 agrawalkhushi18 agrawalkhushi18 approved these changes

@samskillman samskillman Awaiting requested review from samskillman

@kvenkatachala333 kvenkatachala333 Awaiting requested review from kvenkatachala333

+1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

external PR from external contributor release-chore To not include into release notes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sudheer-quad @Neelabh94 @agrawalkhushi18