Skip to content

Add missing blueprints to the index#5279

Merged
aslam-quad merged 1 commit into
GoogleCloudPlatform:developfrom
sudheer-quad:docs/index-entry-gke-a4x-max-bm
Mar 25, 2026
Merged

Add missing blueprints to the index#5279
aslam-quad merged 1 commit into
GoogleCloudPlatform:developfrom
sudheer-quad:docs/index-entry-gke-a4x-max-bm

Conversation

@sudheer-quad

@sudheer-quad sudheer-quad commented Feb 24, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

This PR adds the missing gke-a4x-max-bm , gke-a4 and gke-a4x blueprints entry to the index in examples/README.md and also adds the missing ml-slurm-g4 , ml-slurm-g4 , a4x-maxgpu-4g-metal slurm blueprint entry to the index in examples/machine-learning/README.md

Submission Checklist

NOTE: Community submissions can take up to 2 weeks to be reviewed.

Please take the following actions before submitting this pull request.

  • Fork your PR branch from the Toolkit "develop" branch (not main)
  • Test all changes with pre-commit in a local branch #
  • Confirm that "make tests" passes all tests
  • Add or modify unit tests to cover code changes
  • Ensure that unit test coverage remains above 80%
  • Update all applicable documentation
  • Follow Cluster Toolkit Contribution guidelines #

@github-actions github-actions Bot added the external PR from external contributor label Feb 24, 2026
@gemini-code-assist

gemini-code-assist Bot commented Feb 24, 2026

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello @sudheer-quad, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request integrates the 'gke-a4x-max-bm' blueprint into the project's examples documentation. By updating the 'examples/README.md' file, it ensures that this new blueprint, which leverages GKE with A4X Max node pools, is properly indexed and described, making it readily accessible and understandable for users seeking to deploy such configurations.

Highlights

  • Blueprint Indexing: The 'gke-a4x-max-bm' blueprint has been added to the 'examples/README.md' index, ensuring it is discoverable by users.
  • Blueprint Description: A new section describing the 'gke-a4x-max-bm' blueprint, which provisions a GKE cluster with an A4X Max node pool, has been included.
Changelog
  • examples/README.md
    • Added a new list item for 'gke-a4x-max-bm' in the table of contents.
    • Inserted a detailed description for the 'gke-a4x-max-bm' blueprint, including its purpose and a link to its specific README.
Activity
  • No activity has been recorded on this pull request yet.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

@sudheer-quad sudheer-quad added the release-chore To not include into release notes label Feb 24, 2026
gemini-code-assist[bot]
gemini-code-assist Bot reviewed Feb 24, 2026
View reviewed changes

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly adds the new gke-a4x-max-bm example blueprint to the examples/README.md index, which is a required step for new examples as per the repository's contribution guidelines. The change is straightforward and well-executed. I have one minor suggestion to fix a grammatical error in the description. Otherwise, this looks good to merge.

Comment thread examples/README.md
@sudheer-quad

sudheer-quad commented Feb 24, 2026

Copy link
Copy Markdown
Contributor Author

Reference: #5277

@sudheer-quad sudheer-quad marked this pull request as ready for review February 24, 2026 12:46
@sudheer-quad sudheer-quad requested review from a team and samskillman as code owners February 24, 2026 12:46
vikramvs-gg
vikramvs-gg reviewed Feb 24, 2026
View reviewed changes
Comment thread examples/README.md
@sudheer-quad sudheer-quad marked this pull request as draft February 26, 2026 03:55
@sudheer-quad sudheer-quad force-pushed the docs/index-entry-gke-a4x-max-bm branch from 97bac6f to b670957 Compare March 2, 2026 04:12
@sudheer-quad sudheer-quad changed the title Add gke-a4x-max-bm blueprint to the index Add missing blueprints to the index Mar 2, 2026
@sudheer-quad sudheer-quad force-pushed the docs/index-entry-gke-a4x-max-bm branch 2 times, most recently from 6fe260d to 2d8c769 Compare March 6, 2026 10:19
@sudheer-quad sudheer-quad marked this pull request as ready for review March 17, 2026 04:34
vikramvs-gg
vikramvs-gg previously approved these changes Mar 24, 2026
View reviewed changes
@vikramvs-gg vikramvs-gg dismissed their stale review March 24, 2026 09:33

Recommendation

vikramvs-gg
vikramvs-gg reviewed Mar 24, 2026
View reviewed changes
Comment thread examples/README.md Outdated
@sudheer-quad sudheer-quad force-pushed the docs/index-entry-gke-a4x-max-bm branch from 27eeede to 049f540 Compare March 25, 2026 09:32
@aslam-quad aslam-quad merged commit 3b2c07d into GoogleCloudPlatform:develop Mar 25, 2026
13 of 71 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vikramvs-gg vikramvs-gg vikramvs-gg approved these changes

@kvenkatachala333 kvenkatachala333 kvenkatachala333 approved these changes

@samskillman samskillman Awaiting requested review from samskillman

+1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

external PR from external contributor release-chore To not include into release notes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@sudheer-quad @vikramvs-gg @kvenkatachala333 @aslam-quad