Skip to content

Refactor gcluster deployment path in readme #5219

Merged
aslam-quad merged 1 commit into
GoogleCloudPlatform:developfrom
aslam-quad:a3-highgpu-8g-readme
Feb 10, 2026
Merged

Refactor gcluster deployment path in readme #5219
aslam-quad merged 1 commit into
GoogleCloudPlatform:developfrom
aslam-quad:a3-highgpu-8g-readme

Conversation

@aslam-quad

@aslam-quad aslam-quad commented Feb 10, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Fixed incorrect deployment path in README.

Submission Checklist

NOTE: Community submissions can take up to 2 weeks to be reviewed.

Please take the following actions before submitting this pull request.

  • Fork your PR branch from the Toolkit "develop" branch (not main)
  • Test all changes with pre-commit in a local branch #
  • Confirm that "make tests" passes all tests
  • Add or modify unit tests to cover code changes
  • Ensure that unit test coverage remains above 80%
  • Update all applicable documentation
  • Follow Cluster Toolkit Contribution guidelines #

@gemini-code-assist

gemini-code-assist Bot commented Feb 10, 2026

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello @aslam-quad, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refactors the gcluster deploy command paths within the README.md for the a3-highgpu-8g machine learning example. The change ensures that the deployment commands explicitly reference the full relative paths to the deployment.yaml and blueprint.yaml files, improving the robustness and clarity of the instructions for users.

Highlights

  • Deployment Command Path Refactoring: Updated gcluster deploy commands in the a3-highgpu-8g example's README to use full relative paths for a3high-slurm-deployment.yaml and a3high-slurm-blueprint.yaml. This ensures the commands execute correctly regardless of the user's current working directory.
Changelog
  • examples/machine-learning/a3-highgpu-8g/README.md
    • Updated gcluster deploy commands to use full relative paths for a3high-slurm-deployment.yaml and a3high-slurm-blueprint.yaml.
Activity
  • No human activity has occurred on this pull request yet.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist[bot]
gemini-code-assist Bot reviewed Feb 10, 2026
View reviewed changes

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the gcluster deploy command examples in the a3-highgpu-8g README to use full paths. This is a good change that improves the clarity and correctness of the documentation, making it clear that commands should be run from the repository root. All suggestions have been addressed or removed based on repository rules.

@aslam-quad aslam-quad added the release-chore To not include into release notes label Feb 10, 2026
@aslam-quad aslam-quad marked this pull request as ready for review February 10, 2026 07:54
@aslam-quad aslam-quad requested review from a team and samskillman as code owners February 10, 2026 07:54
shubpal07
shubpal07 reviewed Feb 10, 2026
View reviewed changes
Comment thread examples/machine-learning/a3-highgpu-8g/README.md
shubpal07
shubpal07 reviewed Feb 10, 2026
View reviewed changes
Comment thread examples/machine-learning/a3-highgpu-8g/README.md
shubpal07
shubpal07 requested changes Feb 10, 2026
View reviewed changes

@shubpal07 shubpal07 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We may improve the creation of cluster part using references mentioned.

@shubpal07 shubpal07 self-requested a review February 10, 2026 11:05
@aslam-quad aslam-quad merged commit 0055113 into GoogleCloudPlatform:develop Feb 10, 2026
14 of 96 checks passed
@aslam-quad aslam-quad deleted the a3-highgpu-8g-readme branch February 10, 2026 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@arpit974 arpit974 arpit974 approved these changes

@shubpal07 shubpal07 shubpal07 approved these changes

@samskillman samskillman Awaiting requested review from samskillman

+1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

release-chore To not include into release notes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@aslam-quad @arpit974 @shubpal07