Add precondition checks to disallow setting conflicting consumption options#5062
Conversation
Summary of ChangesHello @kadupoornima, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the GKE node pool blueprint by introducing a crucial validation step. It specifically targets a configuration conflict where both Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
The pull request successfully introduces a crucial precondition check to prevent conflicting spot and enable_queued_provisioning options in GKE node pools. This validation, performed during the blueprint check/generate phase, will significantly improve the user experience by catching configuration errors early and avoiding badRequest errors during Terraform apply. This is a valuable enhancement for the module's robustness and user-friendliness.
…nd enable_queued_provisioning)
c56d038
into
GoogleCloudPlatform:develop
Problem: The blueprint validator did not prevent a user from configuring a GKE node pool with a few conflicting consumption options. While these combinations are syntactically valid in the blueprint, it results in a
badRequesterror from the GKE API during terraform apply. This lead to wasted time deploying and debugging, as the failure occurs late in the terraform apply process.Solution : In this PR, we added precondition checks to prevent conflicting combinations during the blueprint check/generate phase itself for the following:
spot: trueandenable_queued_provisioning: trueoptions cannot be set at the same time.spot: true), then reservation should not be set.Tested these changes locally.