Graduate network/private-service-access to core modules#5029
Conversation
Summary of ChangesHello @SwarnaBharathiMantena, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on graduating the 'private-service-access' module by moving it from the 'community' section to the core 'modules' directory. This change reflects the module's stability and importance, making it a standard offering. The update includes adjusting all internal references across various examples and documentation files to point to the new path, along with implementing a robust redirection mechanism for users still referencing the old path, ensuring a smooth transition and clear guidance. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request primarily re-paths the private-service-access module from community/modules/network/private-service-access to modules/network/private-service-access. This change is reflected across numerous example YAML configuration files, module READMEs, Terraform files (main.tf, variables.tf), and internal configuration files (pkg/config/config.go), indicating a formal relocation of the module within the project structure. There were no review comments provided.
|
community/examples
Examples
example/machine-learning
PR-validation test - success - link |
e07791c
into
GoogleCloudPlatform:develop
The private-service-access module configures private service access for the VPC specified by the network_id variable. It can be used by the Cloud SQL Federation module or to connect Google Cloud NetApp Volumes.
The private-service-access module needs to be moved from the community/modules/network folder to the modules/network folder.
Note: "community/modules/network/private-service-access": "modules/network/private-service-access" has been added to movedModules map in the pkg/config/config.go file. This ensures that any blueprint deployment using the path "community/modules/network/private-service-access" errors out with a message: Error: a module has moved. community/modules/network/private-service-access has been replaced with modules/network/private-service-access. Please update the source in your blueprint and try again.