Skip to content

Enable h4d-vm test to run on Spot VMs#5022

Merged
simrankaurb merged 1 commit intoGoogleCloudPlatform:developfrom
simrankaurb:h4d-spot
Dec 19, 2025
Merged

Enable h4d-vm test to run on Spot VMs#5022
simrankaurb merged 1 commit intoGoogleCloudPlatform:developfrom
simrankaurb:h4d-spot

Conversation

@simrankaurb
Copy link
Contributor

@simrankaurb simrankaurb commented Dec 19, 2025 •
edited
Loading

This pull request enables usage of spot VMs to run tests on h4d machines

The changes involve two files:

  • tools/cloud-build/daily-tests/builds/h4d-vm.yaml: This file is updated to include a "SPOT" provisioning model.
  • tools/cloud-build/daily-tests/tests/h4d-vm.yml: This file is modified to add instance labels for enabling and identifying Spot VM usage.

Submission Checklist

NOTE: Community submissions can take up to 2 weeks to be reviewed.

Please take the following actions before submitting this pull request.

  • Fork your PR branch from the Toolkit "develop" branch (not main)
  • Test all changes with pre-commit in a local branch #
  • Confirm that "make tests" passes all tests
  • Add or modify unit tests to cover code changes
  • Ensure that unit test coverage remains above 80%
  • Update all applicable documentation
  • Follow Cluster Toolkit Contribution guidelines #

@simrankaurb simrankaurb added the release-improvements Added to release notes under the "Improvements" heading. label Dec 19, 2025
@gemini-code-assist
Copy link
Contributor

gemini-code-assist bot commented Dec 19, 2025

Summary of Changes

Hello @simrankaurb, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request integrates Google Cloud Spot Virtual Machines into the h4d daily test suite. By configuring the test environment to provision Spot VMs and dynamically select zones, it aims to reduce testing costs and enhance flexibility without impacting the test execution logic.

Highlights

  • Spot VM Provisioning: The h4d-vm.yaml build configuration now explicitly sets the provisioning_model to "SPOT" for h4d VMs, allowing tests to leverage cost-effective Spot instances.
  • Dynamic Zone Selection: The build process in h4d-vm.yaml has been updated to dynamically determine the available zone using a helper script, removing hardcoded zone assignments.
  • Spot VM Identification: The h4d-vm.yml test configuration now includes instance_labels with h4d_onspot: true and an enable_spot: true flag, facilitating identification and management of Spot VMs within the test environment.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist[bot]
gemini-code-assist bot reviewed Dec 19, 2025
View reviewed changes
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request enables the h4d tests to run on Spot VMs. The changes involve updating the Cloud Build configuration to dynamically find an available zone and modify the test blueprint to use the 'SPOT' provisioning model. The corresponding test definition is also updated to remove hardcoded zones and add flags for Spot VM usage.

My review focuses on the maintainability and correctness of these changes. While the overall approach is sound, I've identified a significant maintainability issue in the sed command used to patch the blueprint in h4d-vm.yaml. The command is brittle due to hardcoded values and incorrect indentation, which could lead to silent failures or invalid configurations in the future. My feedback includes a specific suggestion to make this script more robust.

@simrankaurb simrankaurb changed the title Enable h4d tests to run on Spot VMs Enable h4d-vm test to run on Spot VMs Dec 19, 2025
@simrankaurb simrankaurb marked this pull request as ready for review December 19, 2025 18:39
@simrankaurb simrankaurb requested review from a team and samskillman as code owners December 19, 2025 18:39
@simrankaurb simrankaurb merged commit a848af9 into GoogleCloudPlatform:develop Dec 19, 2025
14 of 74 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@arpit974 arpit974 arpit974 approved these changes

@samskillman samskillman Awaiting requested review from samskillman samskillman is a code owner

+1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

release-improvements Added to release notes under the "Improvements" heading.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@simrankaurb @arpit974