Skip to content

A4X JBVM#4950

Merged
LAVEEN merged 7 commits intoGoogleCloudPlatform:developfrom
LAVEEN:a4xjbvm
Feb 9, 2026
Merged

A4X JBVM#4950
LAVEEN merged 7 commits intoGoogleCloudPlatform:developfrom
LAVEEN:a4xjbvm

Conversation

@LAVEEN
Copy link
Contributor

@LAVEEN LAVEEN commented Dec 8, 2025

Onboarding A4X JBVM

Submission Checklist

NOTE: Community submissions can take up to 2 weeks to be reviewed.

Please take the following actions before submitting this pull request.

  • Fork your PR branch from the Toolkit "develop" branch (not main)
  • Test all changes with pre-commit in a local branch #
  • Confirm that "make tests" passes all tests
  • Add or modify unit tests to cover code changes
  • Ensure that unit test coverage remains above 80%
  • Update all applicable documentation
  • Follow Cluster Toolkit Contribution guidelines #

@LAVEEN LAVEEN requested review from a team and samskillman as code owners December 8, 2025 04:03
@LAVEEN LAVEEN changed the title A4 JBVM A4X JBVM Dec 8, 2025
@gemini-code-assist
Copy link
Contributor

gemini-code-assist bot commented Dec 8, 2025

Summary of Changes

Hello @LAVEEN, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a new, comprehensive blueprint for deploying A4X JBVM instances tailored for high-performance machine learning environments on Google Cloud. It automates the provisioning of GPU-accelerated virtual machines, setting up the necessary networking infrastructure, and installing all required software components such as NVIDIA drivers, CUDA, OpenMPI, and NCCL libraries, including the Google NCCL-GIB plugin. The goal is to provide a streamlined and ready-to-use environment for demanding computational tasks.

Highlights

  • New Blueprint Introduction: A new blueprint for 'a4x-jbvm' has been added, designed for deploying A4X JBVM instances with specific configurations for machine learning workloads.
  • GPU-Accelerated VM Setup: The blueprint configures two 'a4x-highgpu-4g' virtual machines, including specialized networking (VPC and GPU RDMA VPC) and a shared high-scale SSD Filestore for the '/home' directory.
  • Automated Software Installation: A comprehensive startup script automates the installation of critical software components, including NVIDIA drivers, CUDA Toolkit 13, NVIDIA Container Toolkit, Data Center GPU Manager (DCGM), ibverbs-utils, OpenMPI 5.0.8 (compiled with CUDA support), NCCL libraries, and the Google NCCL-GIB plugin.
  • Network Configuration: The deployment includes two standard VPC networks and a GPU RDMA VPC network, all configured with GVNIC for high-performance communication, essential for distributed GPU workloads.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist[bot]
gemini-code-assist bot reviewed Dec 8, 2025
View reviewed changes
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a new example blueprint for deploying an A4X Just-a-Bunch-of-VMs (JBVM) setup. My review has identified several issues, including critical problems with correctness and documentation that will prevent the blueprint from deploying successfully and also violate repository guidelines. Specifically, there's an incorrect variable reference for the instance image. Furthermore, as per the repository's style guide (rule 33), it is critical to update examples/README.md with any new examples, which has not been done in this PR. I've also flagged a high-severity security issue due to an overly permissive SSH firewall rule. Other comments focus on improving the robustness and maintainability of the embedded startup scripts.

sarthakag
sarthakag reviewed Dec 8, 2025
View reviewed changes
Copy link
Contributor

@sarthakag sarthakag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the Github action checks

@LAVEEN LAVEEN marked this pull request as draft December 8, 2025 13:18
@LAVEEN LAVEEN changed the title A4X JBVM A4X JBVM (Do not review) Dec 9, 2025
@LAVEEN LAVEEN force-pushed the a4xjbvm branch 4 times, most recently from 9c3f4c4 to 041d252 Compare December 14, 2025 14:23
@LAVEEN LAVEEN changed the title A4X JBVM (Do not review) A4X JBVM Dec 14, 2025
@LAVEEN LAVEEN requested a review from sarthakag December 14, 2025 14:40
@LAVEEN LAVEEN added the release-key-new-features Added to release notes under the "Key New Features" heading. label Dec 14, 2025
@LAVEEN LAVEEN marked this pull request as ready for review January 20, 2026 05:21
@LAVEEN LAVEEN merged commit abbbbf7 into GoogleCloudPlatform:develop Feb 9, 2026
13 of 75 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bytetwin bytetwin bytetwin approved these changes

@samskillman samskillman Awaiting requested review from samskillman samskillman is a code owner

@sarthakag sarthakag Awaiting requested review from sarthakag

+1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@bytetwin bytetwin

Labels

release-key-new-features Added to release notes under the "Key New Features" heading.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@LAVEEN @bytetwin @sarthakag