Skip to content

Update nccl-rdma manifest in gke a4x#4817

Merged
parulbajaj01 merged 1 commit into
GoogleCloudPlatform:developfrom
parulbajaj01:parul/a4x
Nov 5, 2025
Merged

Update nccl-rdma manifest in gke a4x#4817
parulbajaj01 merged 1 commit into
GoogleCloudPlatform:developfrom
parulbajaj01:parul/a4x

Conversation

@parulbajaj01

@parulbajaj01 parulbajaj01 commented Nov 4, 2025

Copy link
Copy Markdown
Contributor

NCCL RDMA installer manifest was outdated and not working properly. Updated it to the latest version.

Submission Checklist

NOTE: Community submissions can take up to 2 weeks to be reviewed.

Please take the following actions before submitting this pull request.

  • Fork your PR branch from the Toolkit "develop" branch (not main)
  • Test all changes with pre-commit in a local branch #
  • Confirm that "make tests" passes all tests
  • Add or modify unit tests to cover code changes
  • Ensure that unit test coverage remains above 80%
  • Update all applicable documentation
  • Follow Cluster Toolkit Contribution guidelines #

@parulbajaj01 parulbajaj01 requested review from a team and samskillman as code owners November 4, 2025 10:42
@parulbajaj01 parulbajaj01 added the release-improvements Added to release notes under the "Improvements" heading. label Nov 4, 2025
@gemini-code-assist

gemini-code-assist Bot commented Nov 4, 2025

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello @parulbajaj01, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on resolving issues with an outdated NCCL RDMA installer manifest within the GKE A4x example. The primary goal is to ensure the installer functions correctly by updating its core image and simplifying related configurations, thereby improving the reliability and setup process for GPU-accelerated workloads.

Highlights

  • NCCL RDMA Installer Update: The NCCL RDMA installer image has been updated from version v1.0.4 to v1.0.7 to address an outdated and non-working manifest.
  • Configuration Simplification: The gpu_driver_installation_config block has been removed from the gke-a4x.yaml for the nvidia-gb200 accelerator type, streamlining the configuration.
  • Removed Init Container: An initContainer named disable-log-martian, which was previously used to set sysctl parameters for net.ipv4.conf.gpuXrdma0.log_martians, has been removed from the NCCL RDMA installer manifest.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist[bot]
gemini-code-assist Bot reviewed Nov 4, 2025
View reviewed changes

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the NCCL RDMA installer manifest for the GKE A4X example. The changes include updating the installer image to the latest version (v1.0.7) and removing a now-obsolete init container that disabled log_martians. Additionally, a redundant GPU driver configuration that was set to its default value has been removed from the node pool definition, which simplifies the configuration. The changes are well-justified and improve the maintainability and correctness of the example. I have no further comments.

@parulbajaj01 parulbajaj01 merged commit 45afa94 into GoogleCloudPlatform:develop Nov 5, 2025
12 of 66 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vikramvs-gg vikramvs-gg vikramvs-gg approved these changes

@samskillman samskillman Awaiting requested review from samskillman

+1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

release-improvements Added to release notes under the "Improvements" heading.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@parulbajaj01 @vikramvs-gg