Skip to content

Add Managed Lustre support in gke-a4x blueprint#4793

Merged
parulbajaj01 merged 2 commits into
GoogleCloudPlatform:developfrom
parulbajaj01:parul/lustre
Oct 29, 2025
Merged

Add Managed Lustre support in gke-a4x blueprint#4793
parulbajaj01 merged 2 commits into
GoogleCloudPlatform:developfrom
parulbajaj01:parul/lustre

Conversation

@parulbajaj01

@parulbajaj01 parulbajaj01 commented Oct 27, 2025

Copy link
Copy Markdown
Contributor

Enabled the Lustre CSI driver by default in gke-a4x blueprint and added commented out code with instructions to support managed lustre.

Manual testing steps performed:

  1. Deployed the GKE A4X cluster with Managed-Lustre enabled.
  2. Checked if the PVC is bound to the PV: kubectl get pvc
  3. Mounted the PVC in a pod, which will mount the Managed-Lustre file system.
  4. Checked if the pod is running and the volume is mounted: kubectl get pod
  5. Wait for the pod to be in the 'Running' state
  6. Exec into the pod: kubectl exec -it -- /bin/sh
  7. Inside the pod, checked the mount:
    df -h /mnt/lustre
    mount | grep lustre
  8. Managed-Lustre file system was mounted at /mnt/lustre and was able to read/write data to this path from within the container.

Submission Checklist

NOTE: Community submissions can take up to 2 weeks to be reviewed.

Please take the following actions before submitting this pull request.

  • Fork your PR branch from the Toolkit "develop" branch (not main)
  • Test all changes with pre-commit in a local branch #
  • Confirm that "make tests" passes all tests
  • Add or modify unit tests to cover code changes
  • Ensure that unit test coverage remains above 80%
  • Update all applicable documentation
  • Follow Cluster Toolkit Contribution guidelines #

@parulbajaj01 parulbajaj01 requested review from a team and samskillman as code owners October 27, 2025 11:07
@gemini-code-assist

gemini-code-assist Bot commented Oct 27, 2025

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello @parulbajaj01, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly enhances the gke-a4x blueprint by integrating support for Google Cloud's Managed Lustre service. It enables the Lustre CSI driver by default and provides clear, commented-out examples for configuring and deploying Managed Lustre instances, including necessary network and persistent volume setups. This update streamlines the process for users to leverage high-performance shared file systems for their GKE A4X clusters, catering to demanding HPC workloads.

Highlights

  • Managed Lustre CSI Driver Enabled: The Managed Lustre Container Storage Interface (CSI) driver is now enabled by default within the gke-a4x blueprint, streamlining the integration of Lustre file systems for high-performance workloads.
  • Managed Lustre Configuration Examples: Comprehensive commented-out code snippets and instructions have been added to guide users on how to configure and deploy Managed Lustre instances. This includes variables for instance ID, size, and throughput, as well as modules for network setup (Private Service Access, firewall rules) and Persistent Volume creation.
  • Terraform Provider Version Updates: The google and google-beta Terraform provider versions have been upgraded from 6.34.0 to 7.2.0, ensuring compatibility with the latest features and improvements.
  • Dynamic GKE Version Prefix: The GKE cluster's version_prefix is now dynamically configurable via a new variable, offering greater flexibility in specifying the desired Kubernetes version for the cluster.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

@parulbajaj01 parulbajaj01 added the release-improvements Added to release notes under the "Improvements" heading. label Oct 27, 2025
gemini-code-assist[bot]
gemini-code-assist Bot reviewed Oct 27, 2025
View reviewed changes

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds support for Managed Lustre in the gke-a4x blueprint. It enables the Lustre CSI driver by default, updates Google provider versions, and introduces commented-out variables and module definitions for users to configure and deploy a Managed Lustre file system. The changes are well-structured and the accompanying instructions are helpful. My review includes a couple of suggestions to improve the example configuration by removing a hardcoded value and providing a more instructive example for an instance ID, which will make it easier and less error-prone for users to enable this feature.

Comment thread examples/gke-a4x/gke-a4x.yaml Outdated
Comment thread examples/gke-a4x/gke-a4x.yaml Outdated
@parulbajaj01 parulbajaj01 merged commit 740d2b4 into GoogleCloudPlatform:develop Oct 29, 2025
10 of 64 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vikramvs-gg vikramvs-gg vikramvs-gg approved these changes

@samskillman samskillman Awaiting requested review from samskillman

+1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

release-improvements Added to release notes under the "Improvements" heading.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@parulbajaj01 @vikramvs-gg