Simplify condition for github workflow multi-approvers job#4759
Merged
SwarnaBharathiMantena merged 1 commit intoOct 13, 2025
Conversation
bytetwin
approved these changes
Oct 13, 2025
bytetwin
left a comment
Collaborator
There was a problem hiding this comment.
Can you update the description to state that removing the PR triggers doesn't impact the approval workflow
11d577a
into
GoogleCloudPlatform:develop
12 of 63 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The previous update does not fix the issue that multi-approvers(pull_request) job does not re-run upon approval.
Note: Removing the PR triggers doesn't impact the approval workflow
Reason for change: The multi-approvers condition should run when an approval is either submitted or dismissed. The PR state should not directly affect. Note that approvals get dismissed when a new commit is added to a PR. So, that case is not missed with this change.
Submission Checklist
NOTE: Community submissions can take up to 2 weeks to be reviewed.
Please take the following actions before submitting this pull request.