Skip to content

Update multi-approvers Github workflow to trigger the job upon a new approval#4743

Merged
SwarnaBharathiMantena merged 1 commit into
GoogleCloudPlatform:developfrom
SwarnaBharathiMantena:swarnabm/update-multi-approvers-PR-trigger
Oct 10, 2025
Merged

Update multi-approvers Github workflow to trigger the job upon a new approval#4743
SwarnaBharathiMantena merged 1 commit into
GoogleCloudPlatform:developfrom
SwarnaBharathiMantena:swarnabm/update-multi-approvers-PR-trigger

Conversation

@SwarnaBharathiMantena

@SwarnaBharathiMantena SwarnaBharathiMantena commented Oct 9, 2025

Copy link
Copy Markdown
Contributor

In some PRs, upon an additional approval on the PR, the multi-approvers test that failed earlier is not triggered again. One has to either manually re-run the tests by selecting the re-run failed builds option against the options available to the right corner of the PR test, or run the test using the babysit tool.

This update to the multi-approvers workflow will ensure this test re-runs when a new approval is added to the PR.

Note: The if condition includes the pull_request_review of 'dismissed' type as the multi-approvers job should re-run and fail if there are not enough approvals.

Submission Checklist

NOTE: Community submissions can take up to 2 weeks to be reviewed.

Please take the following actions before submitting this pull request.

  • Fork your PR branch from the Toolkit "develop" branch (not main)
  • Test all changes with pre-commit in a local branch #
  • Confirm that "make tests" passes all tests
  • Add or modify unit tests to cover code changes
  • Ensure that unit test coverage remains above 80%
  • Update all applicable documentation
  • Follow Cluster Toolkit Contribution guidelines #

@SwarnaBharathiMantena SwarnaBharathiMantena added the release-chore To not include into release notes label Oct 9, 2025
@SwarnaBharathiMantena SwarnaBharathiMantena force-pushed the swarnabm/update-multi-approvers-PR-trigger branch from 124e6c2 to b65fa03 Compare October 9, 2025 08:14
Comment thread .github/workflows/multi-approvers.yml Outdated
@SwarnaBharathiMantena SwarnaBharathiMantena force-pushed the swarnabm/update-multi-approvers-PR-trigger branch 2 times, most recently from 308e863 to 54d17b1 Compare October 9, 2025 09:25
Comment thread .github/workflows/multi-approvers.yml Outdated
@SwarnaBharathiMantena SwarnaBharathiMantena force-pushed the swarnabm/update-multi-approvers-PR-trigger branch from a45af92 to 3028281 Compare October 10, 2025 04:57
@SwarnaBharathiMantena SwarnaBharathiMantena merged commit 9e52e46 into GoogleCloudPlatform:develop Oct 10, 2025
11 of 62 checks passed
@SwarnaBharathiMantena SwarnaBharathiMantena deleted the swarnabm/update-multi-approvers-PR-trigger branch October 13, 2025 05:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release-chore To not include into release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants