Update multi-approvers Github workflow to trigger the job upon a new approval#4743
Merged
SwarnaBharathiMantena merged 1 commit intoOct 10, 2025
Conversation
124e6c2 to
b65fa03
Compare
bytetwin
requested changes
Oct 9, 2025
308e863 to
54d17b1
Compare
bytetwin
requested changes
Oct 9, 2025
a45af92 to
3028281
Compare
bytetwin
approved these changes
Oct 10, 2025
9e52e46
into
GoogleCloudPlatform:develop
11 of 62 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In some PRs, upon an additional approval on the PR, the
multi-approverstest that failed earlier is not triggered again. One has to either manually re-run the tests by selecting the re-run failed builds option against the options available to the right corner of the PR test, or run the test using the babysit tool.This update to the multi-approvers workflow will ensure this test re-runs when a new approval is added to the PR.
Note: The if condition includes the pull_request_review of 'dismissed' type as the multi-approvers job should re-run and fail if there are not enough approvals.
Submission Checklist
NOTE: Community submissions can take up to 2 weeks to be reviewed.
Please take the following actions before submitting this pull request.