Skip to content

Adding GKE sample for running nvidia-bug-report#4741

Merged
bytetwin merged 1 commit into
GoogleCloudPlatform:developfrom
raushan2016:develop
Oct 13, 2025
Merged

Adding GKE sample for running nvidia-bug-report#4741
bytetwin merged 1 commit into
GoogleCloudPlatform:developfrom
raushan2016:develop

Conversation

@raushan2016

@raushan2016 raushan2016 commented Oct 9, 2025 •
edited by SwarnaBharathiMantena
Loading

Copy link
Copy Markdown
Member

Changes

  • Adding examples on how to run nvidia-bug-report when using COS OS image in GKE as a pod.
  • Renaming from being GCE specific to GCP level so that both GCE and GKE examples is available for COS OS image.

Why

  • Parity with existing example of running nvidia-bug-report on GCE VM with GKE node using COS OS image
  • Running nvidia-bug-report can be challenging as it will require some kernel modules as well as SSH into the GKE node. This approach uses K8s native to run it as K8s Pod using the same image which was previous used for running as docker container for GCE node using COS Image.

Submission Checklist

NOTE: Community submissions can take up to 2 weeks to be reviewed.

Please take the following actions before submitting this pull request.

  • Fork your PR branch from the Toolkit "develop" branch (not main)
  • Test all changes with pre-commit in a local branch #
  • Confirm that "make tests" passes all tests
  • Add or modify unit tests to cover code changes
  • Ensure that unit test coverage remains above 80%
  • Update all applicable documentation
  • Follow Cluster Toolkit Contribution guidelines #

@raushan2016 raushan2016 requested review from a team and samskillman as code owners October 9, 2025 01:09
@raushan2016 raushan2016 mentioned this pull request Oct 9, 2025
Closed
@SwarnaBharathiMantena

SwarnaBharathiMantena commented Oct 9, 2025

Copy link
Copy Markdown
Contributor

I do not see an edit on cluster-toolkit-writers.json. Do you want to push another commit?

@bytetwin

bytetwin commented Oct 9, 2025

Copy link
Copy Markdown
Collaborator

I do not see an edit on cluster-toolkit-writers.json. Do you want to push another commit?

I don't see a need to be added to cluster-toolkit-writers.json. Its mainly for core toolkit team members. Since all of us work on fork model, its not needed.

@SwarnaBharathiMantena SwarnaBharathiMantena added the release-improvements Added to release notes under the "Improvements" heading. label Oct 9, 2025
@SwarnaBharathiMantena

SwarnaBharathiMantena commented Oct 9, 2025

Copy link
Copy Markdown
Contributor

I do not see an edit on cluster-toolkit-writers.json. Do you want to push another commit?

I don't see a need to be added to cluster-toolkit-writers.json. Its mainly for core toolkit team members. Since all of us work on fork model, its not needed.

I removed the "- Added myself to the cluster-toolkit-writers.json to get access to add labels in future." detail from the Changes comment above.

bytetwin
bytetwin requested changes Oct 9, 2025
View reviewed changes
Comment thread community/cos-nvidia-bug-report/bug-report-pod.yaml Outdated
@raushan2016 raushan2016 requested a review from bytetwin October 9, 2025 17:37
@bytetwin

bytetwin commented Oct 10, 2025

Copy link
Copy Markdown
Collaborator

/gcbrun

bytetwin
bytetwin approved these changes Oct 10, 2025
View reviewed changes

@bytetwin bytetwin left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Can you squash the commit into one before merge

@raushan2016
Adding GKE sample for running nvidia-bug-report
ec15abc 
Adding GKE sample for running nvidia-bug-report

Fix the number of GPUs in the pod spec
@raushan2016

raushan2016 commented Oct 10, 2025

Copy link
Copy Markdown
Member Author

LGTM. Can you squash the commit into one before merge

Done

@bytetwin bytetwin enabled auto-merge October 11, 2025 06:20
@bytetwin

bytetwin commented Oct 11, 2025

Copy link
Copy Markdown
Collaborator

@SwarnaBharathiMantena - Need another approval as its external contribution

SwarnaBharathiMantena
SwarnaBharathiMantena approved these changes Oct 13, 2025
View reviewed changes

@SwarnaBharathiMantena SwarnaBharathiMantena left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bytetwin bytetwin merged commit f4d58a2 into GoogleCloudPlatform:develop Oct 13, 2025
11 of 65 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bytetwin bytetwin bytetwin approved these changes

@SwarnaBharathiMantena SwarnaBharathiMantena SwarnaBharathiMantena approved these changes

@samskillman samskillman Awaiting requested review from samskillman

Assignees

No one assigned

Labels

release-improvements Added to release notes under the "Improvements" heading.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@raushan2016 @SwarnaBharathiMantena @bytetwin