Skip to content

minor bug fix on MFT version comparison#4689

Merged
SwarnaBharathiMantena merged 1 commit into
GoogleCloudPlatform:developfrom
ljqg:cos_mft_on_aarach64
Sep 24, 2025
Merged

minor bug fix on MFT version comparison#4689
SwarnaBharathiMantena merged 1 commit into
GoogleCloudPlatform:developfrom
ljqg:cos_mft_on_aarach64

Conversation

@ljqg

@ljqg ljqg commented Sep 24, 2025

Copy link
Copy Markdown
Contributor

Minor bug fix on MFT version comparisons.

When there are multiple MFT version available, there is a minor bug in the comparison logic and would resulted in the following failrue:

  File "/app/gce-cos-nvidia-bug-report.py", line 740, in IdentifyMftKernelModules
    if latest_version is None or current_version > latest_version:
                                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
TypeError: '>' not supported between instances of 'Version' and 'str'

Submission Checklist

NOTE: Community submissions can take up to 2 weeks to be reviewed.

Please take the following actions before submitting this pull request.

  • Fork your PR branch from the Toolkit "develop" branch (not main)
  • Test all changes with pre-commit in a local branch #
  • Confirm that "make tests" passes all tests
  • Add or modify unit tests to cover code changes
  • Ensure that unit test coverage remains above 80%
  • Update all applicable documentation
  • Follow Cluster Toolkit Contribution guidelines #

@ljqg ljqg requested review from a team and samskillman as code owners September 24, 2025 03:49
@SwarnaBharathiMantena SwarnaBharathiMantena added the release-bugfix Added to release notes under the "Bug fixes" heading. label Sep 24, 2025
@SwarnaBharathiMantena SwarnaBharathiMantena merged commit 17063f5 into GoogleCloudPlatform:develop Sep 24, 2025
13 of 64 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release-bugfix Added to release notes under the "Bug fixes" heading.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants