Enable Private Nodes by default in GKE Node Pool#4682
Merged
Conversation
Contributor
|
/gemini review |
Contributor
There was a problem hiding this comment.
Code Review
This pull request modifies the gke-node-pool module to enable private nodes by default, enhancing the security posture of GPU node pools by preventing the allocation of public IP addresses. The change involves updating the default value of the enable_private_nodes variable to true in both the README.md and variables.tf files. I have identified one issue related to the documentation in README.md that needs to be addressed.
ca61a8f to
6c7e817
Compare
shubpal07
previously approved these changes
Nov 4, 2025
Contributor
|
We need to test for other machine families as well like A3 ultra which sets |
shubpal07
approved these changes
Nov 4, 2025
409fce0
into
GoogleCloudPlatform:develop
26 of 64 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Disable public IP allocation by default in GKE node pools.
This is a potential security concern highlighted by the networking team. Fixed it by changing the default value of the
enable_private_nodesvariable in gke-node-pool module totrue.This change was tested by deploying sample blueprints, showing the VMs thus created to have no external IPs (only have internal IPs). A3M and G4 clusters were created successfully and tested before changing this default value.
Network connectivity tests were also performed to verify the deployed clusters were able to access the internet.