Refactoring in gke persistent module#4618
Merged
vikramvs-gg merged 1 commit intoSep 19, 2025
Merged
Conversation
bytetwin
requested changes
Sep 8, 2025
c93b2eb to
37c1bdd
Compare
37c1bdd to
c16c7b2
Compare
bytetwin
approved these changes
Sep 19, 2025
7e1545e
into
GoogleCloudPlatform:develop
12 of 60 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The changes include the following refactoring in gke-persistent-volume module:
This overalls improves the readability and maintainability of the module as the storage types are added to this module in future.