Skip to content

Refactoring in gke persistent module#4618

Merged
vikramvs-gg merged 1 commit into
GoogleCloudPlatform:developfrom
vikramvs-gg:lustre_improvements
Sep 19, 2025
Merged

Refactoring in gke persistent module#4618
vikramvs-gg merged 1 commit into
GoogleCloudPlatform:developfrom
vikramvs-gg:lustre_improvements

Conversation

@vikramvs-gg

Copy link
Copy Markdown
Contributor

The changes include the following refactoring in gke-persistent-volume module:

  1. Map Lookups for Templates and Template Variables instead of nested ternary operators used across the file.
  2. Simplified Content Rendering: pv_content and pvc_content are now generated with single templatefile calls, using the maps to get the correct path and variables.

This overalls improves the readability and maintainability of the module as the storage types are added to this module in future.

@vikramvs-gg vikramvs-gg added the release-module-improvements Added to release notes under the "Module Improvements" heading. label Sep 7, 2025
@vikramvs-gg vikramvs-gg requested review from a team and samskillman as code owners September 7, 2025 16:49
Comment thread modules/file-system/gke-persistent-volume/main.tf Outdated
Comment thread modules/file-system/gke-persistent-volume/main.tf
Comment thread modules/file-system/gke-persistent-volume/outputs.tf Outdated
@vikramvs-gg vikramvs-gg force-pushed the lustre_improvements branch 3 times, most recently from c93b2eb to 37c1bdd Compare September 15, 2025 09:09
@vikramvs-gg vikramvs-gg merged commit 7e1545e into GoogleCloudPlatform:develop Sep 19, 2025
12 of 60 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release-module-improvements Added to release notes under the "Module Improvements" heading.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants