Skip to content

add compact placement to H4D GKE blueprint#4610

Merged
samskillman merged 5 commits into
GoogleCloudPlatform:developfrom
akiki-liang0:gke-h4d-compact
Sep 9, 2025
Merged

add compact placement to H4D GKE blueprint#4610
samskillman merged 5 commits into
GoogleCloudPlatform:developfrom
akiki-liang0:gke-h4d-compact

Conversation

@akiki-liang0

Copy link
Copy Markdown
Contributor

Submission Checklist

NOTE: Community submissions can take up to 2 weeks to be reviewed.

Please take the following actions before submitting this pull request.

  • Fork your PR branch from the Toolkit "develop" branch (not main)
  • Test all changes with pre-commit in a local branch #
  • Confirm that "make tests" passes all tests
  • Add or modify unit tests to cover code changes
  • Ensure that unit test coverage remains above 80%
  • Update all applicable documentation
  • Follow Cluster Toolkit Contribution guidelines #

@akiki-liang0 akiki-liang0 requested review from a team and samskillman as code owners September 5, 2025 02:28
@samskillman samskillman added the release-chore To not include into release notes label Sep 5, 2025
@samskillman samskillman self-assigned this Sep 5, 2025
@samskillman

Copy link
Copy Markdown
Collaborator

/gcbrun

samskillman
samskillman previously approved these changes Sep 5, 2025

@samskillman samskillman left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

bytetwin
bytetwin previously approved these changes Sep 8, 2025

@bytetwin bytetwin left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment thread examples/gke-h4d/gke-h4d.yaml Outdated
Comment thread examples/gke-h4d/gke-h4d.yaml
samskillman
samskillman previously approved these changes Sep 9, 2025

@SwarnaBharathiMantena SwarnaBharathiMantena left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Please ensure the pre-commit checks are successful. Most of the checks mention 'trailing spaces'.

samskillman
samskillman previously approved these changes Sep 9, 2025
abbas1902
abbas1902 previously approved these changes Sep 9, 2025
@samskillman

Copy link
Copy Markdown
Collaborator

/gcbrun

@akiki-liang0 akiki-liang0 dismissed stale reviews from abbas1902 and samskillman via fab2909 September 9, 2025 18:21
akiki-liang0 and others added 2 commits September 9, 2025 20:12
system node pools not needed, confusing for users
akiki-liang0 and others added 3 commits September 9, 2025 20:13
Use node taint to schedule workloads on H4D node pool
Co-authored-by: Sam Skillman <samskillman@google.com>
@samskillman

Copy link
Copy Markdown
Collaborator

/gcbrun

@samskillman samskillman merged commit f111d17 into GoogleCloudPlatform:develop Sep 9, 2025
11 of 65 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release-chore To not include into release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants