Add G4 GKE base blueprints#4560
Merged
kadupoornima merged 1 commit intoSep 10, 2025
Merged
Conversation
Contributor
|
How was the network connectivity tested? |
Contributor
i.e. did you verify all the VMs have the additional NICs attached |
Contributor
Author
Yes, the VMs have 2 NICs - https://screenshot.googleplex.com/AwCZTqq3zoBNwkB |
bytetwin
requested changes
Aug 28, 2025
bytetwin
left a comment
Collaborator
There was a problem hiding this comment.
Since this is a new machine type, can you add an integration test.
5314919 to
bde47f3
Compare
Contributor
Author
I am taking it up soon in a separate task. |
7be4ca3 to
a30b168
Compare
samskillman
reviewed
Sep 3, 2025
692a990 to
f4bf28d
Compare
annuay-google
previously approved these changes
Sep 4, 2025
52f7b99 to
ccc8623
Compare
annuay-google
previously approved these changes
Sep 9, 2025
bytetwin
previously approved these changes
Sep 9, 2025
11f9450
11f9450 to
036ba20
Compare
bytetwin
approved these changes
Sep 10, 2025
1fceded
into
GoogleCloudPlatform:develop
12 of 63 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This blueprint uses GKE to provision a Kubernetes cluster and a G4 node pool, along with networks and service accounts. Information about the G4 machines can be found here.
Manual testing done. Verified that the cluster gets deployed successfully.