Fix filter for gke-nodepool instance_templates#4559
Merged
sharabiani merged 2 commits intoAug 22, 2025
Conversation
samskillman
reviewed
Aug 21, 2025
samskillman
previously approved these changes
Aug 21, 2025
Collaborator
|
Please run the GKE PR tests as well after adding some comments in the code above. Reach out to me if needed. |
samskillman
approved these changes
Aug 22, 2025
samskillman
left a comment
Collaborator
There was a problem hiding this comment.
LGTM. Let's see the tests pass before merging
702865c
into
GoogleCloudPlatform:develop
13 of 62 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Submission Checklist
NOTE: Community submissions can take up to 2 weeks to be reviewed.
Please take the following actions before submitting this pull request.