Fix: Slurm scripts incorrectly identifying all accelerators as GPUs#4498
Merged
sharabiani merged 2 commits intoAug 14, 2025
Merged
Conversation
nick-stroud
approved these changes
Aug 14, 2025
c6a2956
into
GoogleCloudPlatform:develop
11 of 62 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Slurm scripts, utils.py more specifically, considers all accelerators in an instance_template as gpu. This causes wrong gres.conf setup if the accelerator is TPU.
This PR filters accelerators type with "nvidia-" prefix for GPUs.