namespace for gke-modules#4451
Merged
Merged
Conversation
parulbajaj01
requested changes
Jul 25, 2025
parulbajaj01
left a comment
Contributor
There was a problem hiding this comment.
Please fix the pre-commit (update the changes in the readme) and also you can remove the "namespace" keyword from the variable values for all 3 variables.
Contributor
|
/gcbrun |
1 similar comment
Contributor
|
/gcbrun |
Contributor
|
/gcbrun |
parulbajaj01
approved these changes
Jul 29, 2025
bf34199
into
GoogleCloudPlatform:develop
17 of 65 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Submission Checklist
NOTE: Community submissions can take up to 2 weeks to be reviewed.
Please take the following actions before submitting this pull request.
This PR enhances the GKE modules to allow users to specify a custom Kubernetes namespace for deployed resources.
Modules updated:
Users can now provide a namespace variable to deploy resources into a desired namespace. If the namespace variable is not specified, the modules will continue to use their default namespace settings.